Install directory hardcoded in web client build and tests

[Jeff Davis]

In Evergreen master, the /openils install path is hardcoded in web client build and test files (specifically Gruntfile.js and test/karma.conf.js). This presumably means the web client won't build properly, and automated tests won't run correctly, if OpenSRF/EG are installed in some other location.

With other parts of Evergreen, alternate install locations can be specified during the build process. We should support this with the web client as well, perhaps by generating the grunt and karma files from templates during the main EG build.

(Compare bug 1068912.)

[Bill Erickson (berick)]

+1 to templates. As noted in IRC, this may require other changes (build/tools/make_release comes to mind) to ensure Grunt commands execute after ./configure.

[Jeff Davis (jdavis-sitka)]

Hard-coded paths exist in Angular as well as AngularJS, see Open-ILS/src/eg2/karma.conf.js.

[Jeff Davis (jdavis-sitka)]

Working branch user/jeffdavis/lp1662297-no-hardcoded-install-path has a fix:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jeffdavis/lp1662297-no-hardcoded-install-path

I'm not too familiar with autotools, so I just copied the steps for building Apache config. Angular and AngularJS tests ran successfully for me when using an alternate install path (not /openils) with this branch.

As a result of this change, it will be necessary to run configure and make before building the web client. I have updated the installation instructions accordingly. The semi-official Ansible installer and other build tools will likely need to be updated too. I don't think make_release needs any changes since it does not appear to run web client tests.

[Blake GH (bmagic)]

This patch causes the following error when installing Evergreen:

make install

am_importer.conf.example '/openils/conf'
 /usr/bin/mkdir -p '/openils/var/data'
 /usr/bin/install -c -m 644 ./extras/ils_events.xml ../../Open-ILS/examples/hold_notification_template.example ./reporter/report-fail ./reporter/report-success '/openils/var/data'
 /usr/bin/mkdir -p '/openils/share/doc/open-ils'
 /usr/bin/install -c -m 644 ../../Open-ILS/examples/apache_24/eg_startup ../../Open-ILS/examples/apache_24/eg_24.conf ../../Open-ILS/examples/apache_24/eg_vhost_24.conf ../../Open-ILS/web/js/ui/default/staff/test/karma.conf.js ./eg2/karma.conf.js '/openils/share/doc/open-ils'
/usr/bin/install: will not overwrite just-created '/openils/share/doc/open-ils/karma.conf.js' with './eg2/karma.conf.js'
make[3]: *** [Makefile:625: install-docDATA] Error 1
make[3]: Leaving directory '/home/opensrf/repos/Evergreen/Open-ILS/src'
make[2]: *** [Makefile:857: install-am] Error 2
make[2]: Leaving directory '/home/opensrf/repos/Evergreen/Open-ILS/src'
make[1]: *** [Makefile:694: install-recursive] Error 1
make[1]: Leaving directory '/home/opensrf/repos/Evergreen/Open-ILS/src'
make: *** [Makefile:419: install-recursive] Error 1