Install directory hardcoded in web client build and tests

Bug #1662297 reported by Jeff Davis
This bug affects 1 person
Affects Status Importance Assigned to Milestone

Bug Description

In Evergreen master, the /openils install path is hardcoded in web client build and test files (specifically Gruntfile.js and test/karma.conf.js). This presumably means the web client won't build properly, and automated tests won't run correctly, if OpenSRF/EG are installed in some other location.

With other parts of Evergreen, alternate install locations can be specified during the build process. We should support this with the web client as well, perhaps by generating the grunt and karma files from templates during the main EG build.

(Compare bug 1068912.)

tags: added: webstaffclient
Revision history for this message
Bill Erickson (berick) wrote :

+1 to templates. As noted in IRC, this may require other changes (build/tools/make_release comes to mind) to ensure Grunt commands execute after ./configure.

Revision history for this message
Jeff Davis (jdavis-sitka) wrote :

Hard-coded paths exist in Angular as well as AngularJS, see Open-ILS/src/eg2/karma.conf.js.

Changed in evergreen:
status: New → Confirmed
importance: Undecided → Low
Changed in evergreen:
milestone: none → 3.4-beta1
Revision history for this message
Jeff Davis (jdavis-sitka) wrote :

Working branch user/jeffdavis/lp1662297-no-hardcoded-install-path has a fix:;a=shortlog;h=refs/heads/user/jeffdavis/lp1662297-no-hardcoded-install-path

I'm not too familiar with autotools, so I just copied the steps for building Apache config. Angular and AngularJS tests ran successfully for me when using an alternate install path (not /openils) with this branch.

As a result of this change, it will be necessary to run configure and make before building the web client. I have updated the installation instructions accordingly. The semi-official Ansible installer and other build tools will likely need to be updated too. I don't think make_release needs any changes since it does not appear to run web client tests.

tags: added: pullrequest
Galen Charlton (gmc)
Changed in evergreen:
milestone: 3.4-beta1 → 3.4-beta2
Galen Charlton (gmc)
Changed in evergreen:
milestone: 3.4-beta2 → 3.4.1
Changed in evergreen:
milestone: 3.4.1 → 3.4.2
Changed in evergreen:
milestone: 3.4.2 → 3.4.3
Changed in evergreen:
milestone: 3.4.3 → 3.4.4
Changed in evergreen:
milestone: 3.4.4 → 3.5.2
Changed in evergreen:
milestone: 3.5.2 → 3.6.1
tags: added: cleanup
Changed in evergreen:
milestone: 3.6.1 → 3.6.2
Changed in evergreen:
milestone: 3.6.2 → 3.6.3
tags: removed: webstaffclient
Changed in evergreen:
milestone: 3.6.3 → 3.6.4
Changed in evergreen:
milestone: 3.6.4 → 3.7.2
no longer affects: evergreen/3.4
no longer affects: evergreen/3.5
Changed in evergreen:
milestone: 3.7.2 → 3.7.3
no longer affects: evergreen/3.6
Changed in evergreen:
milestone: 3.7.3 → none
Revision history for this message
Blake GH (bmagic) wrote :

This patch causes the following error when installing Evergreen:

make install

am_importer.conf.example '/openils/conf'
 /usr/bin/mkdir -p '/openils/var/data'
 /usr/bin/install -c -m 644 ./extras/ils_events.xml ../../Open-ILS/examples/hold_notification_template.example ./reporter/report-fail ./reporter/report-success '/openils/var/data'
 /usr/bin/mkdir -p '/openils/share/doc/open-ils'
 /usr/bin/install -c -m 644 ../../Open-ILS/examples/apache_24/eg_startup ../../Open-ILS/examples/apache_24/eg_24.conf ../../Open-ILS/examples/apache_24/eg_vhost_24.conf ../../Open-ILS/web/js/ui/default/staff/test/karma.conf.js ./eg2/karma.conf.js '/openils/share/doc/open-ils'
/usr/bin/install: will not overwrite just-created '/openils/share/doc/open-ils/karma.conf.js' with './eg2/karma.conf.js'
make[3]: *** [Makefile:625: install-docDATA] Error 1
make[3]: Leaving directory '/home/opensrf/repos/Evergreen/Open-ILS/src'
make[2]: *** [Makefile:857: install-am] Error 2
make[2]: Leaving directory '/home/opensrf/repos/Evergreen/Open-ILS/src'
make[1]: *** [Makefile:694: install-recursive] Error 1
make[1]: Leaving directory '/home/opensrf/repos/Evergreen/Open-ILS/src'
make: *** [Makefile:419: install-recursive] Error 1

tags: added: needswork
removed: pullrequest
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.