Staff users should be prevented from marking a Long Overdue item Lost

Bug #1661754 reported by Michele Morgan on 2017-02-03
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Undecided
Unassigned
2.10
Undecided
Unassigned
2.11
Undecided
Unassigned

Bug Description

Evergreen 2.11.1
Web Client
Xul Client

This bug is related to bug 1562061 but attempts to addresses only the problem where a staff member chooses a Long Overdue item on a patron's Items Out screen and chooses the Mark Lost action as follows:

- Retrieve a patron record that has a Long Overdue item.
- Select the Long Overdue transaction and choose Mark Item Lost(by patron) from the actions menu.
- On the patron's bills screen, select the now Lost transaction and view the Full Details.

The billings will show a double billing. Both a Lost Materials billing and a Long Overdue Materials billing have been assessed.

Staff users are already prevented from using the Mark Lost function on an already Lost item with the notification ". Similarly, they should be prevented from using the Mark Lost function on a Long Overdue item.

Branch is forthcoming.

Michele Morgan (mmorgan) on 2017-02-03
Changed in evergreen:
assignee: nobody → Michele Morgan (mmorgan)
tags: added: billing webstaffclient
Michele Morgan (mmorgan) on 2017-02-06
Changed in evergreen:
milestone: none → 2.12-beta
Terran McCanna (tmccanna) wrote :

This change would be very helpful for PINES as well.

Changed in evergreen:
status: New → Confirmed
Michele Morgan (mmorgan) wrote :

Working branch is at:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mmorgan/LP_1661784_Prevent_marking_Long_Overdue_items_Lost

This fix prevents Lost processing and Long Overdue processing from running on items that are already in Lost or Long Overdue status. A more elegant solution under bug 1562061 would be preferable, but this small fix will prevent staff users from inadvertently double billing patrons.

Feedback welcome!

Changed in evergreen:
assignee: Michele Morgan (mmorgan) → nobody
tags: added: pullrequest
Kathy Lussier (klussier) on 2017-02-17
Changed in evergreen:
assignee: nobody → Kathy Lussier (klussier)
Kathy Lussier (klussier) wrote :

Ideally, it would be better to see code to address bug 1562061, but, in the meantime, this is a good stop-gap solution to accidentally double billing patrons. Merged to master for inclusion in 2.12 and backported to 2.11 and 2.10.

Changed in evergreen:
assignee: Kathy Lussier (klussier) → nobody
status: Confirmed → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers