Comment 11 for bug 1661688

Jason Stephenson (jstephenson) wrote :

I took a look at this branch and resolved Kathy's error in comment #8. I also changed the code to flesh the hold usr that was added by Dan's branch. We don't need to flesh text fields on a fleshed object. We only need to flesh the user.

I didn't make any other changes to the code, but I did notice that the hold cancellation does not work if the setting is not set to true or false in actor.org_unit_setting. Deleting the row leads to the hold not being canceled, even if the box is checked in the dialog. I suspect this happens because of line 33 in Open-ILS/web/js/ui/default/staff/circ/services/circ.js. It does exactly what the previous line does and pull an aous valued directly into a Boolean. I suspect that if the setting isn't set in aous or is null, then we get something neither true nor false and the code doesn't work. I'm not sure this needs to be addressed since existing code does the same. I'm just mentioning it in light of my comment #10.

My code is rebased on master and can be found in working/collab/dyrcona/LP1661688_hold_checkout_other_patron;a=shortlog;h=refs/heads/collab/dyrcona/LP1661688_hold_checkout_other_patron

I'll leave any other potential modifications open for discussion.