Webstaff: User can register workstation at org_unit that can't have users.

[Jason Stephenson]

A user can register a workstation at an org unit that can't have users in the webstaff client. The XUL Staff Client does not allow this, these org units are grayed out in the selection list.

A branch to fix this in in working/user/dyrcona/lp1648922-hide-cant-have-users-ous
http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dyrcona/lp1648922-hide-cant-have-users-ous

[Chris Sharp (chrissharp123)]

I can confirm this issue. I was able to register a workstation at the "PINES" level, which cannot have users.

[Ben Shum (bshum)]

Tested and can see that the solution does remove from the list any org units which should not have workstations registered at.

Do we have any opinions though on whether it should still list these units somehow as grayed out? (like in XUL client) Or it's good enough that it doesn't show them options they can't use anyways? I think we can safely go with the latter, but had to ask...

Retargeting towards 2.12-beta for final review next week.

[Michele Morgan (mmorgan)]

I tested this code and found that, while the org units which cannot have users do not appear in the dropdown list, it is still possible to register a workstation at the Consortium level.

If the workstation isn't currently registered, the Consortium populates the box When the page loads and it is possible to register at that level. The Consortium also populates the box if the registration is removed and the page reloaded.

Regarding the question of whether greyed out org units should appear in the list, I would concur with Ben that it's fine to not show the org units that are not eligible to be chosen.

Removint the pullrequest and adding needsrepatch.

[Kathy Lussier (klussier)]

Adding a note that the dropdown only defaults to CONS when the admin user is registering the workstation. For other users, the dropdown will default to the user's home library.

I agree with Ben and Michele regarding the non-display of org units not eligible to be chosen.

[Mike Rylander (mrylander)]

Michele, would not having a default at all be better? If so, that's easy to do with the "nodefault" and "label" attributes for eg-org-selector.

[Michele Morgan (mmorgan)]

Mike, I'm not sure I like the idea of no default at all. I wouldn't want the users that have only one working location to have to choose.

Since Kathy pointed out that the appearance of the consortium is only going to affect admin users, I'm reversing myself. The fix works for the staff users in our libraries, I think we admin users can deal with occasionally being presented with the consortium.

Signoff branch on the way.

[Michele Morgan (mmorgan)]

Here's my signoff branch:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mmorgan/LP_1648922_Hide_orgs_in_workstation_registration_signoff

[Kathy Lussier (klussier)]

Thank you Jason and Michele! Merged to master for inclusion in 2.12.