Webstaff: Can't remove registered workstation at root of user's org/permission tree.

Bug #1648918 reported by Jason Stephenson on 2016-12-10
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Low
Unassigned

Bug Description

While looking into a webstaff client issue encountered by another, I registered a workstation for the admin user in a concerto database at the CONS.

I discovered that I could not later remove it, though I could register and remove any other workstation. The Remove button is dimmed out for this workstation. (Screen shots attached.)

The reason is that the CONS org_unit is first (i.e. zero) in the perm ou array and so the check for indexOf() returns 0, a false value. The check should be indexOf() != -1.

git branch is at working/user/dyrcona/lp1648918-remove-workstation-fix
http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dyrcona/lp1648918-remove-workstation-fix

Jason Stephenson (jstephenson) wrote :

Here's a screenshot showing that I can remove the BR1 workstation.

description: updated
tags: added: pullrequest
Changed in evergreen:
milestone: none → 2.next
Michele Morgan (mmorgan) on 2017-02-03
Changed in evergreen:
assignee: nobody → Michele Morgan (mmorgan)
Michele Morgan (mmorgan) wrote :

Tested this as follows:

Registered a workstation at CONS level
Registered a workstation at SYS1 level
Selected the SYS1 registration, clicked Use Now
Redirected to Login screen, logged in as SYS1 workstation
Navigated to registered workstations
Chose CONS
Clicked Remove, the workstation was removed

Also:

Registered a workstation at CONS level
Selected the CONS registration, clicked Use Now
Redirected to Login screen, logged in as CONS workstation
Navigated to registered workstations
Chose CONS
Clicked Remove, the workstation was removed
Redirected to register a workstation

In all test cases I was able to successfully remove the CONS workstation

My signoff branch is at:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mmorgan/lp_1648918-signoff

tags: added: signedoff
Changed in evergreen:
assignee: Michele Morgan (mmorgan) → nobody
Galen Charlton (gmc) wrote :

Pushed to master for inclusion in 2.12. Thanks, Jason and Michele!

Changed in evergreen:
status: New → Confirmed
importance: Undecided → Low
status: Confirmed → Fix Committed
Ben Shum (bshum) on 2017-02-12
Changed in evergreen:
milestone: 2.next → 2.12-beta
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers