Incorrect fpadd method referenced in Money.pm

[Brent Mills]

Evergreen 2.9.1
OpenSRF 2.4.0
Debian Jessie 8.6
Postgres 9.3.15

I was curious why I was seeing log entries like

--

Can't locate object method "fpadd" via package "OpenILS::Application::AppUtils" at /usr/local/share/perl/5.20.2/OpenILS/Application/Circ/Money.pm line 997

--

from what I can gather, this is happening when staff are trying to adjust balances on certain negative balanced Lost Items to zero. Possibly caused by some combination of Lost/Void Library Settings?

For this library (Set to True):
-Void lost item billing when claims returned
-Void lost item processing fee when claims returned
-Void processing fee on lost item return
-Void overdue fines when items are marked lost
-Prohibit negative balance on bills (DEFAULT)
-Prohibit negative balance on bills lost materials
-Prohibit negative balance on bills for overdue materials

I'm assuming the correct method should be "fpsum", not "fpadd" as Open-ILS/src/perlmods/lib/OpenILS/Application/AppUtils.pm currently only lists "fpsum" and "fpdiff".

Am going to try changing fpadd to fpsum and seeing what happens...

++ thanks to Dan Wells for letting me bug him about it.

[Jeff Davis (jdavis-sitka)]

We're seeing this error on 2.12. I'm testing a fix along the lines suggested by bmills.

[Jeff Davis (jdavis-sitka)]

Fix seems to work for us - here's the branch:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jeffdavis/lp1647852-error-on-adjust-to-zero

[Dan Wells (dbw2)]

Brent and I talked this over months ago, but it completely fell off my radar. Thanks for taking care of it, Jeff!

Pushed to master through rel_2_11.