Incorrect fpadd method referenced in Money.pm

Bug #1647852 reported by Brent Mills on 2016-12-06
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Undecided
Unassigned
2.11
Undecided
Unassigned
2.12
Undecided
Unassigned

Bug Description

Evergreen 2.9.1
OpenSRF 2.4.0
Debian Jessie 8.6
Postgres 9.3.15

I was curious why I was seeing log entries like

--

Can't locate object method "fpadd" via package "OpenILS::Application::AppUtils" at /usr/local/share/perl/5.20.2/OpenILS/Application/Circ/Money.pm line 997

--

from what I can gather, this is happening when staff are trying to adjust balances on certain negative balanced Lost Items to zero. Possibly caused by some combination of Lost/Void Library Settings?

For this library (Set to True):
-Void lost item billing when claims returned
-Void lost item processing fee when claims returned
-Void processing fee on lost item return
-Void overdue fines when items are marked lost
-Prohibit negative balance on bills (DEFAULT)
-Prohibit negative balance on bills lost materials
-Prohibit negative balance on bills for overdue materials

I'm assuming the correct method should be "fpsum", not "fpadd" as Open-ILS/src/perlmods/lib/OpenILS/Application/AppUtils.pm currently only lists "fpsum" and "fpdiff".

Am going to try changing fpadd to fpsum and seeing what happens...

++ thanks to Dan Wells for letting me bug him about it.

Jeff Davis (jdavis-sitka) wrote :

We're seeing this error on 2.12. I'm testing a fix along the lines suggested by bmills.

Jeff Davis (jdavis-sitka) wrote :
Changed in evergreen:
milestone: none → 2.12.2
milestone: 2.12.2 → 3.0-alpha
status: New → Confirmed
tags: added: pullrequest
Dan Wells (dbw2) on 2017-05-09
Changed in evergreen:
assignee: nobody → Dan Wells (dbw2)
Dan Wells (dbw2) wrote :

Brent and I talked this over months ago, but it completely fell off my radar. Thanks for taking care of it, Jeff!

Pushed to master through rel_2_11.

no longer affects: evergreen/3.0
Changed in evergreen:
status: Confirmed → Fix Committed
assignee: Dan Wells (dbw2) → nobody
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers