Web Staff Client - Boolean Filters in Reporter

Bug #1642337 reported by Terran McCanna on 2016-11-16
22
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Evergreen
Medium
Unassigned

Bug Description

Boolean filters in the Reports interface no longer give the prompt to "Click OK for TRUE and Cancel for FALSE." Instead, the user has to know what value to type in. (See screenshot.)

Terran McCanna (tmccanna) wrote :
Kathy Lussier (klussier) wrote :

A dropdown menu or radio buttons with the True / False values would work well here.

Changed in evergreen:
status: New → Confirmed
importance: Undecided → Medium
Jason Boyer (jboyer) wrote :

Given that the egConfirmDialog allows the OK and Cancel button labels to be changed, it could be used so the user can actually click True or False buttons, making things even simpler.

Kyle Huckins (khuckins) wrote :

Going on Jason's suggestion, I've pushed up a branch that resolves this issue: http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/khuckins/lp1642337-boolean-filters-in-reporter

OK and Cancel buttons have been changed to "True" and "False"(using the values of TEMPLATE_CONF_TRUE and TEMPLATE_CONF_FALSE respectively), and change the value of boolean filters to true or false. This is conditional on the datatype being a boolean, so other filter types will still bring up the egPromptDialog as usual.

Changed in evergreen:
assignee: nobody → Kyle Huckins (khuckins)
tags: added: pullrequest
Changed in evergreen:
assignee: Kyle Huckins (khuckins) → nobody
Kathy Lussier (klussier) wrote :

Thanks for your work on this Kyle! It mostly worked for me, but I did encounter a bit of odd behavior when trying to change a boolean value.

If the value is set to 'true' and I select the option to change the value, the dialog doesn't appear for me. Instead, I jump up a bit in the screen and nothing happens to the boolean field. If no value is set or if it is set to false, the dialog appears as expected with the True / False options. I created a screencast here showing the behavior - https://drive.google.com/file/d/1Kx24DWJA5hUkEst7X8pgBuN1lXGqT2TK/view

I see the following in the Console when this occurs:

angular.js:14199 TypeError: c.replace is not a function
    at g (angular.js:12442)
    at k (angular.js:12595)
    at new $uibModal.open.controller (ui.js:416)
    at Object.invoke (angular.js:4771)
    at R.instance (angular.js:10592)
    at ui-bootstrap-tpls.min.js:2
    at angular.js:16696
    at m.$eval (angular.js:17994)
    at m.$digest (angular.js:17808)
    at b.$apply (angular.js:18102)

Kathy Lussier (klussier) on 2018-03-22
tags: added: needsrepatch
removed: pullrequest
Jason Boyer (jboyer) wrote :

Kyle's branch was on the right track, but egConfirmDialog doesn't like it when the message param isn't a string. Here's a branch that signs off on his commit and adds one that turns bools into strings before sending the value to the dialog. It also adds an <Unset> string to the Reporter strings that can be used more in the future as the UI is polished up. (or stripped out entirely as it's currently used only once.)

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads / working/user/jboyer/lp1642337_reporter_bool

tags: added: pullrequest
removed: needsrepatch webstaffclient
Changed in evergreen:
milestone: none → 3.3-beta1
Changed in evergreen:
milestone: 3.3-beta1 → 3.3-rc
Changed in evergreen:
milestone: 3.3-rc → 3.3.1
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Bug attachments