Web Staff Client - Non-Cataloged Circulations

Bug #1642042 reported by Terran McCanna
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned
2.12
Fix Released
Medium
Unassigned

Bug Description

In the 2.11 web client:

I can successfully check out non-cataloged items to a patron account through the web client (and I can verify that they are registered to the account by looking at it through the 2.11 xul client), but they do not appear on the Non-Cataloged Circulations tab in the web client.

Revision history for this message
Kathy Lussier (klussier) wrote :

Hi Terran,

Did you try refreshing the patron account? I tested this on 2.11 and on master. In both cases, I had to refresh the patron account to see the non-cataloged circs. Let me know if that works for you.

I would like to see the non-cataloged circs update immediately without refresh as circs for barcoded items are.

Revision history for this message
Terran McCanna (tmccanna) wrote :

Kathy - No, I didn't try refreshing. And yes, I agree they should update the screen immediately just as cataloged items do.

Revision history for this message
Andrea Neiman (aneiman) wrote :

confirmed in 2.11 & 2.12 -- refresh needed to display new noncat circs

Changed in evergreen:
status: New → Confirmed
Revision history for this message
Bill Erickson (berick) wrote :

Testing code from bug #1635737 I noticed this issue as well. I believe the code is already trying to display the non-cataloged items, but other code along the way is failing, down in the work log tracking:

angular.js:14199 TypeError: Cannot read property 'family_name' of undefined
    at Object.service.record (ui.js:872)
    at Object.service.munge_resp_data (circ.js:290)
    at circ.js:158
    at angular.js:16696
    at m.$eval (angular.js:17994)
    at m.$digest (angular.js:17808)
    at angular.js:18033
    at f (angular.js:6045)
    at angular.js:6324

Changed in evergreen:
assignee: nobody → Bill Erickson (berick)
Revision history for this message
Bill Erickson (berick) wrote :

Well, that was a drastic oversimplification. There were a number of issues to address, not the least of which is that it didn't do what I thought it did. I've pushed a fix:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1642042-webstaff-noncat-worklog

From the commit:

Update non-cat counts in the patron summary side bar and show the full set of non-cat circs in the Non-Cataloged Circulations tab as non-cat circs occur in the patron checkout interface.

Consistent with the XUL client, avoid updating tab-level (i.e. "total") 'items out' counts with non-cat circs.

Adds a new work log action for 'noncat_checkout' so the correct data can be extracted. As with the XUL client, this appears in the work log as a 'checkout' with no copy.

tags: added: pullrequest
Changed in evergreen:
milestone: none → 3.0-alpha
assignee: Bill Erickson (berick) → nobody
Revision history for this message
Galen Charlton (gmc) wrote :

Pushed to master and rel_2_12. Thanks, Bill!

Changed in evergreen:
importance: Undecided → Medium
status: Confirmed → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.