Broken cover art fallback image should be transparent

Bug #1639004 reported by Jeff Davis
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Low
Unassigned
2.10
Fix Released
Low
Unassigned
2.11
Fix Released
Low
Unassigned

Bug Description

In all versions of Evergreen, the existing 1x1 pixel image for broken cover art (Open-ILS/web/opac/images/blank.png) is not actually transparent. It probably should be.

Revision history for this message
Jeff Davis (jdavis-sitka) wrote :

There's a fix in branch user/jeffdavis/lp1639004-actually-transparent-nocover:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commitdiff;h=208325c9aa1d359e12014b505e6ac2898efd464f

Thanks to Jonathan Schatz for noticing the issue and providing a replacement PNG.

tags: added: pullrequest
Changed in evergreen:
milestone: none → 2.next
Changed in evergreen:
assignee: nobody → Terran McCanna (tmccanna)
Revision history for this message
Terran McCanna (tmccanna) wrote :

I have confirmed that the new image is indeed transparent.

I have tested this code and consent to signing off on it with my name, Terran McCanna, and my email address, <email address hidden>.

tags: added: signedoff
Changed in evergreen:
assignee: Terran McCanna (tmccanna) → nobody
Revision history for this message
Kathy Lussier (klussier) wrote :

Thank you Jonathan, Jeff and Terran! Merged to master and backported to release 2.11 and 2.10.

Changed in evergreen:
status: New → Fix Committed
importance: Undecided → Low
milestone: 2.next → 2.12-rc
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.