invoiceable item search fails because of wrong datatype

[Chris Sharp]

When searching for items to link to an invoice (within an invoice, click the "Search" tab), all searches are failing with the error "Event: 2002:DATABASE_QUERY_FAILED -> The attempt to query to the DB failed". Further investigation shows a PostgreSQL wrong type error, trying to use text as an integer - specifically it is using the provider name rather than the provider ID.

JSON query from the opensrf logs is attached.

[Chris Sharp (chrissharp123)]

Oh,

Evergreen 2.9.1
OpenSRF 2.4.1
PostgreSQL 9.4
Ubuntu 14.04 LTS

[Chris Sharp (chrissharp123)]

We were able to confirm the issue here at the Hack-A-Way. One more data point is that this fails on *closed* invoices. If you click the "Reopen" button, then do a search, it works as expected.

[Chris Sharp (chrissharp123)]

Bill discovered that when the invoice is closed, the edit pane displaying the invoice summary is in read-only mode, and that the provider ID is read as the provider name. Rather than fixing that problem, we agree that it makes more sense to just disable the Search tab when the invoice is closed.