Comment 26 for bug 1635386

I poked at this on an off all day hoping to get it into the RC, but I think it needs more eyes now. I've refactored it a fair bit to make it simpler and more consistent. Here is the branch:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dbwells/lp1635386-visual-cues-for-bills-item-status-signoff_refactored

working/user/dbwells/lp1635386-visual-cues-for-bills-item-status-signoff_refactored

Please see the new commit for the list of changes. Also note, it probably makes more sense if you diff the whole branch now against master (or HEAD^^) rather than looking at the commits separately.

Finally, I noticed that the colors in this branch are different than current XUL, using orange for overdues, then red for long overdue, then dark red for lost. I did not make that change, but found it very sensible, so I left it that way. I know there is an argument to be made for keeping it the same as the old client, but there is also one to made for this sort of logical progression of "reddening". If we are going to make the change, now is the time, so I left it, but it wouldn't be hard to swap them around.