Comment 4 for bug 1623955

Revision history for this message
Dan Wells (dbw2) wrote :

Thanks, Kathy! Pushed to master through 2.10.

For later reference, this block of code was never meant to normalize, per se. It's a workaround to prevent "normal" record content links from accidentally containing search grammar. It's origin can be seen in a58bb07326a5. That said, I don't see that '.' ever had special meaning in our search grammar, so maybe chalk this up to some extra zeal.

At some point we should probably work out a bona fide encoding scheme for special search characters (a la URL encode, though perhaps not that exactly). On the other hand, we got nearly four good years out of this current fix, so why not keep riding :)