web client: You can checkout materials to patrons retrieved with an inactive card

[Kathy Lussier]

In the xul client, if you retrieve a patron with an inactive barcode, the Barcode entry box on the checkout screen is disabled, making it impossible to check material out to that patron.

In webby, the Barcode entry box is active, and staff is able to check out material to the patron using the inactive card.

[Billy Horn (bhorn)]

I have been looking into this issue and I've noticed the logic seems to be there to make this work. I was working with a test patron that had overdues and whose card shouldn't have been active but it kept coming up with the issue mentioned. I decided to edit the patron and look at their information and noticed they were still marked as active, and when I toggled the option and saved, the barcode on checkout was properly disabled.

So I'm wondering if the problem is actually that the the active state isn't properly disabled when a patron becomes deactivated.

[Kathy Lussier (klussier)]

Hi Billy,

No, this is something different. I was testing a use case where the patron loses a library card. The steps staff typically take at this point is to edit the patron record and then replace the barcode with a new one. The first barcode stays on the patron record, but becomes inactive.

Let's say the patron returns to the library with the old, lost card. If the patron is retrieved with that barcode, the barcode entry box should be disabled.

[Bill Erickson (berick)]

I believe this is referring to the actor.card.active field, not the actor.usr.active field. Simplest way to create an inactive card is to use the "Replace Barcode" action in the patron editor. The replaced barcode will be set as active = false.

The web staff checkout.js code is checking (among other things) the active state of the user's main/primary card, but it's not checking the activate state of the card used to retrieve the user.

[Billy Horn (bhorn)]

I have pushed a commit here http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/bhorn/lp1621799-disable-checkout-for-inactive-patrons

This adds a function fetchedWithInactiveCard to activate the disable checkout if an inactive card was used

[Kathy Lussier (klussier)]

Thank you Billy. Works for me! Picked to master for inclusion in 2.12. Congrats on your first commit to Evergreen!