webclient: Patron registration form and copy editor do not require stat cat fields configured to be required

[Kathy Lussier]

Patron and copy stat cat fields can be configured to be required. However, the web client is not recognizing that these fields are required.

1. Neither the patron registration form or copy editor provide any visual cue that the stat cat is required.

2. Both forms can be submitted even when required stat cat fields have no value.

[Billy Horn (bhorn)]

While working on this card I have noticed on the copies edit page that none of the fields are set to be required is that intended?

[Billy Horn (bhorn)]

I have pushed a commit here http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/bhorn/LP1618949-patron-and-copy-stat-cat-fields-configure-required

This only addresses the patron side of the stat_cats so far.

[Billy Horn (bhorn)]

For the copies side of this problem it looks like the check for required doesn't work. It seems like the easiest solution would be to configure the copies edit page to accept required arguments. Another option since most of the selections are drop down based and all of the values that need to be required so far just set their first entry as the default value I could try to do the same thing with the stat_cats. If either of these ideas sound good or if another solution would be preferable please let me know how people would like to proceed.

[Bill Erickson (berick)]

Removing assignee since it's been idle for a while.

[Bill Erickson (berick)]

Pushed a new branch:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1618949-patron-required-stat-cats

1. Sign-off for Billy's commit, with some tweaking of the commit message for readability.
2. Additional commit to fix a formatting problem in the form introduced by Billy's commit, plus some other minor code formatting fixes (removing commented out code, nesting div repairs, breaking long lines).

[Bill Erickson (berick)]

Opened a separate bug to address the copy editor issue, so that this bug can be resolved with the patron editor fixes: bug #1686459.

[Kathy Lussier (klussier)]

Thank you Billy and Bill! Works for me. Merged to master and release 2.12