Magical statuses not so magical - possible for staff to edit items into or out of magical statuses

Bug #1616980 reported by Michele Morgan on 2016-08-25
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Medium
Unassigned
2.12
Medium
Unassigned

Bug Description

The "magical statuses", which currently include:

1 - Checked out
3 - Lost
6 - In transit
8 - On holds shelf
16 - Long Overdue
18 - Canceled Transit

Should be disabled in the copy editor. It should not be possible for a staff member editing an item to put the item into, or take the item out of one of these statuses.

In certain circumstances this can be foiled. Using "Checked out" as an example, a copy can be put into any magical status as follows:

- xul Copy editor:

1. Choose to "Edit Item Attributes" on an Available copy.
2. Click the Status field to edit
3. Type "c" until "Checked out" appears in the Status field.
4. Click "Apply"
5. Click "Modify Copies"

- xul Unified Editor

1. Set the library setting "Unified Volume/Item Creator/Editor" to True. Close client and relaunch.
2. Choose to "Edit Items/Volumes per Bib" on an Available copy.
3. Click the Status field to edit
4. Type "c" until "Checked out" appears in the Status field.
5. Click "Apply"
6. Click "Re-barcode / Update Items"

- Web client copy editor:

1. Choose to "Edit Items" on an Available copy.
2. Status field is fully editable. Click to open the dropdown
3. Click "Checked out"
4. Click "Save & Exit"

A copy can be taken out of a magical status as follows:

- xul Copy Editor - not possible to take an item out of a magical status.

- xul Unified Editor

1. Set the library setting "Unified Volume/Item Creator/Editor" to True. Close client and relaunch.
2. Choose to "Edit Items/Volumes per Bib" on an Checked out copy.
3. Click the Status field, which is fully editable.
4. Select "Available".
5. Click "Apply"
6. Click "Re-barcode / Update Items"

- Web Client Copy Editor:

1. Choose to "Edit Items" on an Checked out copy.
2. Status field is fully editable. Click to open the dropdown
3. Click "Available"
4. Click "Save & Exit"

Michele Morgan (mmorgan) on 2016-08-26
description: updated
Andrea Neiman (aneiman) wrote :

Confirmed 2.12.1, both XUL and web client as Michele describes in all cases.

Changed in evergreen:
status: New → Confirmed
Chris Sharp (chrissharp123) wrote :

Adding a link here to a related bug I opened almost simultaneously: https://bugs.launchpad.net/evergreen/+bug/1616170

Changed in evergreen:
assignee: nobody → Jason Etheridge (phasefx)
Jason Etheridge (phasefx) wrote :

For now we're consolidating some webstaff bug fixes into collab/phasefx/webstaff-bugs

This particular bug should be fixed with
http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commitdiff;h=fb2d29c18b5d5630fe299fdbd12b7885a0b9170c

Jason Etheridge (phasefx) wrote :

hrmm, we may want to move

createSimpleUpdateWatcher('status',$scope.magic_status_list);

into the .then() for magic_status_list; not sure if there might be a race condition there (particularly if get_magic_statuses ever truly becomes async in the future)

Andrea Neiman (aneiman) wrote :

I have tested this code and consent to signing off on it with my name, Andrea Neiman and my email address, <email address hidden>

tags: added: pullrequest signedoff
Jason Etheridge (phasefx) wrote :

Just a note, I only tackled the web client here. I poked at the XUL but it seemed too thorny.

Changed in evergreen:
milestone: none → 3.0-alpha
Andrea Neiman (aneiman) wrote :

Since Jason's fix only addresses the webby bits, I've copied the XUL parts into a new ticket -- see bug 1695921 for the XUL version of this.

Galen Charlton (gmc) on 2017-06-19
Changed in evergreen:
assignee: Jason Etheridge (phasefx) → nobody
importance: Undecided → Medium
Galen Charlton (gmc) wrote :

Pushed to master and rel_2_12. Thanks, Jason and Andrea!

Changed in evergreen:
status: Confirmed → Fix Committed
Galen Charlton (gmc) wrote :

Also note bug 1698838

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers