SIP Return Screen Message OK

Bug #1613335 reported by Blake GH
This bug affects 1 person
Affects Status Importance Assigned to Milestone

Bug Description

Some SIP software looks for that screen message "OK". It was removed in a previous version of Evergreen. This is the thread for bringing it back.

Revision history for this message
Blake GH (bmagic) wrote :
Revision history for this message
Jason Stephenson (jstephenson) wrote :

My first thought is that needs to be configurable. The OK message was removed because some self checks had problems with it. They would display an error message to the patron that just said "OK." Patrons and staff find that behavior confusing.

I suggest added a setting at the institution or account level to control whether or not the OK message is returned.

Revision history for this message
Thomas Berezansky (tsbere) wrote :

I disagree with the "OK" message being brought back as it causes spurious messages on a number of clients, which is why it was removed in the first place.

Given that, before we even think about putting anything back, what software needs it and why?

And, if we do put it back, I think it needs to be an *optional*, perhaps per-login, setting to do so as there are valid reasons for it not being there instead of the always-there patch you are submitting.

tags: added: sip
Revision history for this message
Jason Boyer (jboyer) wrote :

I've re-implemented this with a login setting at this branch:;a=shortlog;h=refs/heads/user/jboyer/lp1613335_sip_patron_ok / working/user/jboyer/lp1613335_sip_patron_ok

To test: apply the patch and send a Patron Status Message for a user that is in good standing. You should receive no screen message. Add the parameter want_patron_ok="true" to the login for that client, restart Evergreen and try again; this time you should receive a screen message of OK for that user. There is no SIPServer-side change required.

Jason Boyer (jboyer)
tags: added: pullrequest
Jason Boyer (jboyer)
Changed in evergreen:
importance: Undecided → Low
milestone: none → 3.4.3
Jason Boyer (jboyer)
Changed in evergreen:
milestone: 3.4.3 → 3.5-alpha
Michele Morgan (mmorgan)
Changed in evergreen:
milestone: 3.5-beta →
Jason Boyer (jboyer)
Changed in evergreen:
milestone: → 3.8-beta
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers