Improvements to My Account Holds Screens

[Kathy Lussier]

A followup to bug 1275118, bug 1576502, and bug 1611815. The My Account holds and holds history screens could use the following improvements:

- The active, status, activate and fulfillment time columns are all displaying information about the hold status. Rather than using separate columns, let's display this information in one status column, only showing the information that is pertinent to the user.

- The hold queue position is helpful for holds that have not yet been captured (holds that are waiting for copies and those that are frozen), but adds clutter to the screen once the hold is on its way or has been filled. Let's remove it when it's not needed.

- The holds history page uses different styles from the holds, items out, and checkout history page. There should be more uniformity with those other pages.

I'll post a work-in-progress branch once I grab the LP number.

[Kathy Lussier (klussier)]

The work-in-progress branch is available at http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/kmlussier/lp1612274-improved-myopac-holds-screens

In addition to the above, we'll also be adding more css classes to specific statuses and dates to give some flexibility to Evergreen sites that might want to highlight available holds or activation dates with a different style.

[Kathy Lussier (klussier)]

Adding a pullrequest tag to this one. The above working branch:

- moves data from the Active, Activate, and Date Fulfilled columns into the Status column, simplifying the interface.
- removes the holds queue position from the display if the hold has already been captured.
- Adds CSS classes for each of the statuses and the dates to allow for greater customization. Default styles have been added so that 'Available' will now display in green and 'Suspended' will display in red.

I did not address the issue with the inconsistent styles between the holds history page and the other My Account grids. After further investigation, I consider that issue to be a bug and will file a new LP report.

Before: http://www.screencast.com/t/Ecx4b1a1
After: http://www.screencast.com/t/SpBfLwrvAda

Many thanks to Galen for the suggestion to include all of the status-like data into one status column.

[Kathy Lussier (klussier)]

Adding a note that the new bug to address style issues with this and other My Account screens was filed at https://bugs.launchpad.net/evergreen/+bug/1614807. Although the code in this bug will lead to some nice improvements for the Holds screen, we will have an even better better Holds screen for 2.11 if we also merge bug 1614807 and bug 1612364 before the general release.

[Kathy Lussier (klussier)]

Resolved conflicts against current master and force-pushed an update to http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/kmlussier/lp1612274-improved-myopac-holds-screens

[Mike Rylander (mrylander)]

Perfect, thanks! Picked to master.