"Classic Circulation View" PINES reporting source providing inaccurate counts

Bug #1610246 reported by Chris Sharp on 2016-08-05
This bug affects 2 people
Affects Status Importance Assigned to Milestone

Bug Description

Because the reporter.classic_current_circ view definition includes an inner join to actor.usr_address on actor.usr.billing_address (which may actually be null), circulations for a user without a billing address are excluded. Branch on the way.

Evergreen 2.9.1+
OpenSRF 2.4.1
Ubuntu 14.04 LTS
PostgreSQL 9.4

Changed in evergreen:
assignee: nobody → Chris Sharp (chrissharp123)
Chris Sharp (chrissharp123) wrote :

As promised: http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/csharp/lp1610246_fix_classic_current_circ_view

I'm not including a DB upgrade script since the PINES views are not assumed to be installed in other Evergreen implementations. If you want this fix, just re-run the Open-ILS/src/sql/Pg/example.reporter-extension.sql script after the above branch is applied.

tags: added: pullrequest
tags: added: reports
Galen Charlton (gmc) wrote :

For folks who may not be sure whether or not they're using that reporting source, the following SQL query will give a list of the names of Clark Kent reports that used reporter.classic_current_circ:

select r.name, r.create_time from reporter.report r join reporter.template t on (t.id = r.template) where t.data ~ '"rccc"';

Changed in evergreen:
milestone: none → 2.11-beta
Changed in evergreen:
importance: Undecided → High
milestone: 2.11-beta → 2.next
Changed in evergreen:
importance: High → Medium
Chris Sharp (chrissharp123) wrote :

Targeting to 2.12.1 - this fix should definitely be available to users who depend on the affected PINES view.

Changed in evergreen:
milestone: 2.next → 2.12.1
Changed in evergreen:
milestone: 2.12.1 → 2.12.2
Kathy Lussier (klussier) on 2017-05-17
Changed in evergreen:
assignee: Chris Sharp (chrissharp123) → nobody
Galen Charlton (gmc) wrote :

Tested and pushed to master and rel_2_12, along with an upgrade note for the release notes. Thanks, Chris!

Changed in evergreen:
status: New → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers