misc_util.tt2 code for edition should stop at the 250 field

Bug #1592934 reported by Jim Keenan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned
2.10
Fix Released
Medium
Unassigned
2.9
Fix Released
Medium
Unassigned

Bug Description

Currently, the misc_util.tt2 file includes the 534 and 775 file fields under the edition section of the code. The code checks for the 250 edition field and then, in a series of ORs ( || ) falls through the 534 and the 775. The problem is the 534 and the 775 are for other (i.e. different) editions of the work, not for the work being returned.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jkeenan/lp1592934-misc_util-code-for-edition-should-stop-at-250-field

Tags: pullrequest
Revision history for this message
Jim Keenan (jkeenan) wrote :

I am posting a fix.

Kathy Lussier (klussier)
Changed in evergreen:
status: New → Confirmed
importance: Undecided → Medium
Revision history for this message
Jim Keenan (jkeenan) wrote :
description: updated
tags: added: pullrequest
Kathy Lussier (klussier)
Changed in evergreen:
milestone: none → 2.11-beta
Revision history for this message
Kathy Lussier (klussier) wrote :

Thanks Jim!

For reference, I looked at the LoC docs.

Tag 534 is "an original item when the main portion of the bibliographic record describes a reproduction of that item and the data differ"

Tag 775 is "Entry for another available edition of the target item (horizontal relationship). When a note is generated from this field, the introductory phrase Other editions available: may be generated based on the field tag for display."

I concur that both should be removed from the main Editions statement. I've merged your fix to master and backported to 2.10 and 2.9. Congrats on your first code contribution!

Changed in evergreen:
status: Confirmed → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.