Staff copy counts do not include peer bib copies

[Dan Wells]

EG 2.10

The asset.staff_ou_record_copy_count() function does not account for peer bib copies, but the corresponding public version, asset.opac_ou_record_copy_count() does. The "opac" version simply uses asset.opac_visible_copies, but the staff version is trying to include invisible copies, so it does not take advantage of that table and the surrounding logic.

To test, create a record with no physical copies, but with a peer bib copy, then run:

select * from asset.record_copy_count(1,123,'f');

vs.

select * from asset.record_copy_count(1,123,'t');

where '1' is your main org_unit, '123' is your record ID, and 't'/'f' is the 'is_staff' flag. The public view will return copy info, but the staff will not.

[a. bellenir (abellenir)]

in concerto dataset, eg/opac/record/24 says there are 32 copies (includes the peer bib) if the user is not authenticated, but only 31 (excludes the peer bib) if the user is logged in.