| 2016-05-23 17:58:55 |
Josh Stompro |
description |
EG 2.8.4
It looks to me like the ability to edit the message for hold denied because of age hold protection in templates/opac/parts/hold_error_messages.tt2 [1] no longer works because of this commit [2] from 2012. Now the error message is contained in /templates/opac/parts/place_hold_result.tt2 [3].
It seems like you can only set one message that covers the cases where the user is allowed to override the ITEM_AGE_PROTECTED and when they are not allowed to override.
It would be nice if the message from hold_error_messages.tt2 was used when no override is allowed, and if both were stored in the same file to keep message customization in one place for upgrades.
I tried including a check for override_possible so instead of
# display:
(hdata.age_protect ?
you would have:
# display:
((hdata.age_protect && override_possible) ?
This seem to bring back the behavior I was expecting. I'll create a branch for others to look at.
1 - http://git.evergreen-ils.org/?p=Evergreen.git;a=blob_plain;f=Open-ILS/src/templates/opac/parts/hold_error_messages.tt2;hb=HEAD
2 - http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=a663dfed41126ba4607e500ccda85dd9fa113789
Josh |
EG 2.8.4
It looks to me like the ability to edit the message for hold denied because of age hold protection in templates/opac/parts/hold_error_messages.tt2 [1] no longer works because of this commit [2] from 2012. Now the error message is contained in /templates/opac/parts/place_hold_result.tt2 [3].
It seems like you can only set one message that covers the cases where the user is allowed to override the ITEM_AGE_PROTECTED and when they are not allowed to override.
It would be nice if the message from hold_error_messages.tt2 was used when no override is allowed, and if both were stored in the same file to keep message customization in one place for upgrades.
I tried including a check for override_possible so instead of
# display:
(hdata.age_protect ?
you would have:
# display:
((hdata.age_protect && override_possible) ?
This seem to bring back the behavior I was expecting. I'll create a branch for others to look at.
1 - http://git.evergreen-ils.org/?p=Evergreen.git;a=blob_plain;f=Open-ILS/src/templates/opac/parts/hold_error_messages.tt2;hb=HEAD
2 - http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=a663dfed41126ba4607e500ccda85dd9fa113789
3 - http://git.evergreen-ils.org/?p=Evergreen.git;a=blob;f=Open-ILS/src/templates/opac/parts/place_hold_result.tt2;h=5cf09c11009923c5b7f9ed245b27d23f703707d7;hb=HEAD#l88
Josh |
|
