Force "Include inactive patrons?" on patron reg duplicate search
Bug #1576435 reported by
Jeff Davis
This bug affects 3 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Evergreen |
Fix Released
|
Medium
|
Unassigned | ||
2.10 |
Fix Released
|
Medium
|
Unassigned | ||
2.11 |
Fix Released
|
Medium
|
Unassigned |
Bug Description
Evergreen 2.9+
Per bug 1217052, duplicate patron checking in the patron registration interface now includes inactive patrons. However, in the XUL client, if you click on the link "Found X patron(s) with the same name," the resulting patron search does not always include inactive patrons by default; instead, the value of the "Include inactive patrons?" checkbox is cached from your last patron search, as usual. To avoid confusion, inactive patrons should always be included when arriving at a patron search via that link.
I am unsure if a similar issue exists in the web client.
Changed in evergreen: | |
assignee: | Jeff Davis (jdavis-sitka) → nobody |
Changed in evergreen: | |
assignee: | nobody → Terran McCanna (tmccanna) |
Changed in evergreen: | |
assignee: | Terran McCanna (tmccanna) → nobody |
no longer affects: | evergreen/2.9 |
Changed in evergreen: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
I've pushed a fix for the XUL client to branch user/jeffdavis/ lp1576435- dupe-patron- search- inactive- checkbox in the working repo:
http:// git.evergreen- ils.org/ ?p=working/ Evergreen. git;a=commitdif f;h=81f6caa
To test:
1. Do a patron search with the "Include inactive patrons?" box unchecked. This will ensure that it defaults to unchecked for your next patron search.
2. Create two patron accounts with the same first given name and family name. Mark one of these accounts as inactive.
3. Begin registering a third patron with the same first given name and family name. After entering those names, a link should appear in the registration interface saying "Found 2 patron(s) with the same name." Click that link.
4. Clicking the link opens up a new tab with a patron search. The "Include inactive patrons?" box will be unchecked, and the search results will include only one of your test accounts; the inactive account will not appear.
5. Apply this patch on the server and clear the cache in your staff client.
6. Open a new tab in the staff client and begin registering another patron, once again using the same first given name and family name. Again, you should get a duplicate patron link. Click it.
7. In the resulting patron search, the "Include inactive patrons?" box should automatically be checked, and results should include your inactive test patron.