Angular patron editor post-2.10 misc. bugs

Bug #1564685 reported by Bill Erickson on 2016-04-01
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Medium
Unassigned

Bug Description

Evergreen 2.10.1

Omnibus branch en-route to resolve the following angular patron editor issues:

1. Avoid warning on duplicate username when the username is owned by the patron being edited.

2. When a username regex is present, consider both regex-compliant usernames and an equal match on the barcode as valid usernames, even if the barcode is not regex-compliant. (It usually isn't).

3. Instead of disabling the Save buttons, allow the user to click Save or Save/Clone when invalid fields are present, but display an alert (and prevent save) instead. This is consistent w/ the XUL client and better clarifies why the action is not allowed.

4. Allow all addresses to be deleted on a user unless the org unit setting for requiring an address is true.

5. Misc. repairs to enforcing required fields. Of note, county and state specifically are required now if the matching org setting is true.

6. Consistent (small) sizes of checkboxes for boolean fields -- they done got real big.

7. Removing the last address should not hide the New Address button. It should always be visible.

8. Linked addresses should not be editable from the cloned account. Only the lead account.

9. Only attempt to save stat cat values for stat cats that are within scope.

Bill Erickson (berick) wrote :
tags: added: pullrequest
Changed in evergreen:
milestone: none → 2.10.2
Galen Charlton (gmc) on 2016-04-01
Changed in evergreen:
assignee: nobody → Galen Charlton (gmc)
importance: Undecided → Medium
Bill Erickson (berick) wrote :

Pushed a fix to prevent linked/cloned address editing when loading a cloned user after cloning is done.

Kathy Lussier (klussier) wrote :

I know gmcharlt is looking at this branch, but I'm adding a quick note that the bug fixes work for me. I added my sign-off at:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/kmlussier/lp1564685-ang-patron-reg-post-2.10-misc-bugs

Thanks for your work on this Bill!

Kathy

Galen Charlton (gmc) wrote :

Pushed to master and rel_2_10. Thanks Bill and Kathy!

Changed in evergreen:
status: New → Fix Committed
assignee: Galen Charlton (gmc) → nobody
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers