Description for patron username format setting is misleading

[Kathy Lussier]

The description for the patron username format OU setting is misleading. It says:

Regular expression defining the patron username format, used for patron registration and self-service username changing only.

My testing has found that the regex is not consulted at patron registration nor is it consulted when editing the patron record.

The description should be updated to accurately identify which interfaces consult this setting. I can create a branch with the updated description, but would first like confirmation on when this setting is consulted. From what I can tell, it's not updated when patron's udpate their username in the OPAC. Is it only consulted at user self-registration?

[Bill Erickson (berick)]

The org setting is loaded and referenced in both the TPAC and XUL client code. I think we just need to fix the code to work in both.