TPAC Show More/Fewer Details Button does not work with show_more_details.default set to true

Bug #1548993 reported by Jason Stephenson on 2016-02-23
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Undecided
Unassigned
2.10
Undecided
Unassigned
2.9
Undecided
Unassigned

Bug Description

Evergreen version: 2.9.2 (probably affects 2.8.0+)
OpenSRF version: N/A
PostgreSQL version: N/A

With show_more_details.default set to true in opac/parts/config.tt2 the Show More Details/Show Fewer Details button in the OPAC does not work.

While the button will toggle its name and its own state, the view does not change and always displays more details even when Show Fewer Details has been selected.

The button does work correctly if the setting is set to false, but then it shows fewer details by default.

This was observed in Evergreen 2.9.2 and very recent master.

Changed in evergreen:
status: New → Confirmed
Changed in evergreen:
milestone: none → 2.next
assignee: nobody → Jason Stephenson (jstephenson)
Jason Stephenson (jstephenson) wrote :

The branch in working/user/dyrcona/lp1548993-detail-record-view-patch works in simple testing.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dyrcona/lp1548993-detail-record-view-patch

I'm loading it on our training/test server for more test driving, but I think it is ready for a pullrequest tag and more testing by others.

tags: added: pullrequest
Changed in evergreen:
assignee: Jason Stephenson (jstephenson) → nobody
Jason Stephenson (jstephenson) wrote :

Removed the pullrequest tag while I test some additional changes to have the state of the Show More/Fewer Details button remembered across searches.

I'll like force push over top of the previous branch and add the pullrequest tag back when I think it is working.

tags: removed: pullrequest
Jason Stephenson (jstephenson) wrote :

OK. I have added a commit to the branch to remember the state of the Show More/Fewer Details button across searches. I made this a separate commit in case the consensus ends up being that we want to stick with the original behavior of it clearing when starting a new search.

I've tried it out on concerto and it pretty much works. I noticed that the state does get cleared if you hit 'Clear Form' on advanced search. I'll leave that as desired behavior for now. If someone else wants to try and change that, feel free.

tags: added: pullrequest
Changed in evergreen:
assignee: nobody → Jeanette Lundgren (jlundgren)
Jeanette Lundgren (jlundgren) wrote :

I have tested this code and consent to signing off on it with my name, Jeanette Lundgren and my email address <email address hidden>

Changed in evergreen:
assignee: Jeanette Lundgren (jlundgren) → nobody
tags: added: signedoff
removed: pullrequest
tags: added: pullrequest
Kathy Lussier (klussier) wrote :

Thank you Jason and Jeanette! I added Jeanette's and my own sign-offs and merged to master and 2.10.

I'm leaving 2.9 open for now. There were some minor conflicts to resolve, and I didn't have enough time to address them before wrapping up for the day. I will take care of them later tonight or tomorrow.

Changed in evergreen:
status: Confirmed → Fix Committed
Kathy Lussier (klussier) wrote :

Resolved the conflicts in the 2.9 branch and merged to master.

Changed in evergreen:
milestone: 2.next → 2.11-alpha
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers