config.circ_matrix_matchpoint and config.hold_matrix_matchpoint need a description field

Bug #1545115 reported by Jane Sandberg on 2016-02-12
2
Affects Status Importance Assigned to Milestone
Evergreen
Wishlist
Unassigned

Bug Description

Circ and hold rules are extremely complex. It would be quite helpful to have a field for people to add comments, notes, or descriptions that help when reviewing these rules in either the staff client or the db.

Jane Sandberg (sandbej) on 2016-02-12
description: updated
Galen Charlton (gmc) on 2016-02-16
Changed in evergreen:
importance: Undecided → Wishlist
milestone: none → 2.next

Agreed, this would be nice.

---Sent from iPhone

** Changed in: evergreen

   Importance: Undecided => Wishlist

** Changed in: evergreen

    Milestone: None => 2.next

--
You received this bug notification because you are subscribed to

Evergreen.

Matching subscriptions: evergreenbugs

https://bugs.launchpad.net/bugs/1545115

Title:

  config.circ_matrix_matchpoint and config.hold_matrix_matchpoint need a

  description field

Status in Evergreen:

  New

Bug description:

  Circ and hold rules are extremely complex. It would be quite helpful

  to have a field for people to add comments, notes, or descriptions

  that help when reviewing these rules in either the staff client or the

  db.

To manage notifications about this bug go to:

https://bugs.launchpad.net/evergreen/+bug/1545115/+subscriptions

Rogan Hamby (rogan-hamby) wrote :

After talking with Dyrcona at the conference about this I went to find that not only is there one but I had commented on it! I tossed together a simple branch for this on the db level available at user/rogan/lp1545115_matrix_descriptions

I tested it and it worked fine for me. Included is a pg_tap test to test for the prescence of the columns which I tested as well.

Jane Sandberg (sandbej) wrote :

Awesome! Thanks, Rogan. Quick question, would that new column just automatically start to display in the staff client? Or would there need to be some additional configuration there?

Rogan Hamby (rogan-hamby) wrote :

Hi Jane,

That patch is just for database support which would help those who do admin in db and is a pre-req for staff client. The staff client requires a small (and I mean very small) additional bit of work to support it.

I took a shot at it and I admit my testing was very quick but this worked on my test box for adding the description field to the display grid and editing interfaces in the staff client for the hold and circ match points:

user/rogan/lp1545115_matrix_desciptions_w_staff_client

I also added the patch this time.

Rogan Hamby (rogan-hamby) wrote :

Oh, I should mention the second commit branch I posted is squashed to have the database stuff in it as well so you would only need the second patch / branch I posted.

Jane Sandberg (sandbej) wrote :

Thanks for all your work on this, Rogan. What would it take to get this into master/future releases?

Kathy Lussier (klussier) wrote :

Hi Jane,

If you're interested, I could load Rogan's code on a Sandbox to give you an opportunity to test and sign off on it.

Kathy

Kathy Lussier (klussier) on 2016-11-08
tags: added: pullrequest
Jane Sandberg (sandbej) wrote :

Hi Kathy,

Sorry for the delayed response! I'd be happy to test it in a sandbox!

  -Jane

Galen Charlton (gmc) on 2017-04-25
Changed in evergreen:
assignee: nobody → Galen Charlton (gmc)
Galen Charlton (gmc) wrote :

Tested and signed off. The signoff branch includes a couple follow-up patches that (a) consolidate the database updates into one script and (b) add release notes: user/gmcharlt/lp1545115_signoff

tags: added: signedoff
Changed in evergreen:
assignee: Galen Charlton (gmc) → nobody
Jason Stephenson (jstephenson) wrote :

I'll give this a whirl, since I recall speaking to Rogan about it at the 2016 conference and thinking it was a good idea.

Changed in evergreen:
assignee: nobody → Jason Stephenson (jstephenson)
Jason Stephenson (jstephenson) wrote :

The field just shows up in the staff clients.

All of the tests succeed and I was able to add and edit the description field in the webstaff client as well as the XUL staff client.

That's good enough for me. Pushed to master for 3.0.

Changed in evergreen:
milestone: 3.next → 3.0-alpha
assignee: Jason Stephenson (jstephenson) → nobody
status: New → Fix Committed
Jeremiah Miller (jeremym-t) wrote :

Nice. Thanks for submitting this, Jane.

We've long been using/abusing the script_test field for that purpose in our circ rules, and wishing there were something equivalent for hold rules.

Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers