Patron search code does not recognize empty patron group

Bug #1537812 reported by Mike Rylander
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Mike Rylander
Won't Fix
Won't Fix

Bug Description

In some situations, the patron search code will send an empty or NULL patron group string as part of the search parameters. This is not recognized and causes long (to the point of timing out) search calls. This can be avoided by checking for the presence of a search value.

Revision history for this message
Mike Rylander (mrylander) wrote :

And, here's the branch:;a=shortlog;h=refs/heads/user/miker/lp1537812-patron_search_timeout

It is not clear where the long-running queries are coming from, though it is
likely either the actual patron search interface or from the duplicate check
performed during patron registration. Therefore, testing is made particularly

This is backport-able, and should be, IMO.

tags: added: pullrequest
Changed in evergreen:
milestone: → 2.10-beta
Revision history for this message
Ben Shum (bshum) wrote :

Well... I tested the patch as given and encountered some problems.

1) there's a missing semi-colon after the last changed line @addr_key_list; without it storage fails to start and Evergreen is super unhappy.

2) I tried searching for patrons and I keep coming up with no results.

So I think something is broken here. Passing back to Mike for some more eyes.

tags: added: needsrepatch
removed: pullrequest
Changed in evergreen:
assignee: nobody → Mike Rylander (mrylander)
status: New → Triaged
importance: Undecided → Medium
Changed in evergreen:
milestone: 2.10-beta → 2.10-rc
Galen Charlton (gmc)
Changed in evergreen:
milestone: 2.10-rc → none
Changed in evergreen:
milestone: none →
milestone: → none
no longer affects: evergreen/2.8
no longer affects: evergreen/2.9
Changed in evergreen:
milestone: none →
Revision history for this message
Galen Charlton (gmc) wrote :

Also noting that patch applies due to the accent-squashing change; removing milestone targets for now.

Revision history for this message
Terran McCanna (tmccanna) wrote :

I'm not sure how to test this, but adding in needsrebase tag since the patch is several years old and presumably needs rebasing before it can be tested.

tags: added: needsrebase patron
removed: needsrepatch
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.