webclient: Precat checkouts force a circ modifier

Bug #1537217 reported by Kathy Lussier on 2016-01-22
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Undecided
Unassigned
2.10
Undecided
Unassigned
2.11
Undecided
Unassigned

Bug Description

The web client does not allow a precat checkout with an "Unset" circulation modifier as is currently possible in the xul client.

Some systems do not use circulation modifiers for all of their materials and will need the ability to add a precat without a circulation modifier. Also, this menu should default to the Unset option.

Kyle Huckins (khuckins) on 2016-10-04
Changed in evergreen:
assignee: nobody → Kyle Huckins (khuckins)
Kyle Huckins (khuckins) wrote :

I've put a commit up here: http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=60a41963d18c9732f8c43d48ecf35bce30763789

It was originally coded to default to the first possible circ modifier, so this was a matter of making sure there would be an option that would keep the circ modifier as null, and dropping the default setting.

tags: added: pullrequest
Kyle Huckins (khuckins) wrote :

I realised I linked to the commit here, rather than the branch itself - http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/khuckins/lp1537217-precat-checkouts-modifier

I amended the commit to be a bit more useful, as it was written less with a testing user in mind, and more with a developer in mind. This should be a bit more readable.

Bill Erickson (berick) on 2016-10-13
Changed in evergreen:
milestone: none → 2.11.1
assignee: Kyle Huckins (khuckins) → nobody
status: New → Confirmed
Changed in evergreen:
milestone: 2.11.1 → 2.next

tested on https://mlnc3.noblenet.org/eg/staff/

I have tested this code and consent to signing off on it with my name, [Christine Burns] and my email address, <email address hidden>.

tags: added: signedoff
Kathy Lussier (klussier) wrote :

Thank you Kyle and Christine! Merged to master and backported to release 2.10 and 2.11.

Changed in evergreen:
status: Confirmed → Fix Committed
Ben Shum (bshum) on 2017-02-12
Changed in evergreen:
milestone: 2.next → 2.12-beta
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers