SIP prevents renewal when user has any blocking standing penalties

[Jeff Godin]

SIP currently prevents renewal when a user has any blocking standing penalties, even when the block list for a given penalty does not block renewal.

When handling a Renew (29) message, one of the values consulted is the SIP patron object's renew_ok value, which is currently just a copy of their charge_ok value.

This means that anything blocking checkout will also block renewal (via SIP).

Included in the checks for charge_ok is an explicit assumption that standing penalty ids 1 and 2 will block (though their block_list may have been modified), and that any standing penalties with a non-null block_list will block.

[Blake GH (bmagic)]

This seems to be working.
http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/blake/LP1534283_SIP_prevents_renewal_when_user_has_any_blocking_standing_penalties

[Mike Rylander (mrylander)]

Pushed to master, thanks!