Overdues adjusted via lost (or long overdue) processing get an incorrect note ("VOIDED FOR BACKDATE")

[Dan Wells]

Evergreen 2.8+

If you void/adjust an overdue, but don't supply a reason, the code automatically adds "VOIDED FOR BACKDATE" to the billing note. This is obviously wrong for overdues adjusted due to lost (or long overdue) processing.

Branch is coming soon...

[Dan Wells (dbw2)]

Here is a branch for 2.9+

working/user/dbwells/lp1526547_fix_lost_lod_overdue_adj_note

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dbwells/lp1526547_fix_lost_lod_overdue_adj_note

Will post a 2.8 version in the near future. This also needs a test of some kind.

[Dan Wells (dbw2)]

Okay, force pushed an update to the same branch. It now makes the note wording even more consistent across all types of voiding/adjusting. The branch is now two commits.

It should also be noted that without this branch, adjusted overdue fines have no note at all on the adjustments.

[Kathy Lussier (klussier)]

Hi Dan,

I just tested this branch and see that the problem Brent reported is resolved. However, when fines are adjusted for backdating, I'm not seeing a reason for the account adjustment. This is on a system where the prohibit negative balance settings are enabled. Could that be added?

Thanks!
Kathy

[Dan Wells (dbw2)]

Kathy, thanks for testing. You are right, it looks like I missed one of the two backdate code paths (there's always a second path, right?). I pushed what I hope to be the fix to the same branch. Can you give it whirl and see how it goes? Thanks!

Dan

[Kathy Lussier (klussier)]

Thanks Dan! Looks good to me. I've merged to master and backported to 2.9.

[Dan Wells (dbw2)]

If any are itching to fix this up, here is a 2.8-ized branch:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dbwells/lp1526547_fix_lost_lod_overdue_adj_note-rel_2_8

working/user/dbwells/lp1526547_fix_lost_lod_overdue_adj_note-rel_2_8

Just one commit now.

[Dawn Dale (ddale)]

I was unable to log into the client and also the OU selector for
workstation registration is only display the Consortium. I was unable to test the fix for this bug.

Thanks, Dawn