Overdues adjusted via lost (or long overdue) processing get an incorrect note ("VOIDED FOR BACKDATE")

Bug #1526547 reported by Dan Wells on 2015-12-15
14
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Evergreen
Medium
Unassigned
2.8
Undecided
Unassigned
2.9
Undecided
Unassigned

Bug Description

Evergreen 2.8+

If you void/adjust an overdue, but don't supply a reason, the code automatically adds "VOIDED FOR BACKDATE" to the billing note. This is obviously wrong for overdues adjusted due to lost (or long overdue) processing.

Branch is coming soon...

Dan Wells (dbw2) on 2015-12-15
Changed in evergreen:
assignee: nobody → Dan Wells (dbw2)
importance: Undecided → Medium
Dan Wells (dbw2) wrote :

Here is a branch for 2.9+

working/user/dbwells/lp1526547_fix_lost_lod_overdue_adj_note

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dbwells/lp1526547_fix_lost_lod_overdue_adj_note

Will post a 2.8 version in the near future. This also needs a test of some kind.

tags: added: needstest
Changed in evergreen:
assignee: Dan Wells (dbw2) → nobody
Dan Wells (dbw2) wrote :

Okay, force pushed an update to the same branch. It now makes the note wording even more consistent across all types of voiding/adjusting. The branch is now two commits.

It should also be noted that without this branch, adjusted overdue fines have no note at all on the adjustments.

Kathy Lussier (klussier) wrote :

Hi Dan,

I just tested this branch and see that the problem Brent reported is resolved. However, when fines are adjusted for backdating, I'm not seeing a reason for the account adjustment. This is on a system where the prohibit negative balance settings are enabled. Could that be added?

Thanks!
Kathy

Dan Wells (dbw2) wrote :

Kathy, thanks for testing. You are right, it looks like I missed one of the two backdate code paths (there's always a second path, right?). I pushed what I hope to be the fix to the same branch. Can you give it whirl and see how it goes? Thanks!

Dan

Kathy Lussier (klussier) wrote :

Thanks Dan! Looks good to me. I've merged to master and backported to 2.9.

Changed in evergreen:
status: New → Fix Committed
Changed in evergreen:
milestone: 2.next → 2.10-beta
Dan Wells (dbw2) wrote :

If any are itching to fix this up, here is a 2.8-ized branch:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dbwells/lp1526547_fix_lost_lod_overdue_adj_note-rel_2_8

working/user/dbwells/lp1526547_fix_lost_lod_overdue_adj_note-rel_2_8

Just one commit now.

tags: added: pullrequest
removed: needstest
Changed in evergreen:
status: Fix Committed → Fix Released
Dawn Dale (ddale) wrote :

I was unable to log into the client and also the OU selector for
workstation registration is only display the Consortium. I was unable to test the fix for this bug.

Thanks, Dawn

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers