Cannot disable password reset in TPAC
Bug #1526543 reported by
Dan Wells
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Evergreen |
Fix Released
|
Low
|
Unassigned | ||
2.8 |
Fix Released
|
Low
|
Unassigned | ||
2.9 |
Fix Released
|
Low
|
Unassigned |
Bug Description
Evergreen 2.8+
We expect Boolean options in config.tt2 to be 'true' or 'false', but the code is simple asking 'IF reset_password', which is true for either value. Instead, match on the string (as we do in other places). Branch is incoming!
Changed in evergreen: | |
milestone: | 2.next → 2.10-beta |
Changed in evergreen: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Branch at:
working/ user/dbwells/ lp1526543_ reset_password_ disable
http:// git.evergreen- ils.org/ ?p=working/ Evergreen. git;a=shortlog; h=refs/ heads/user/ dbwells/ lp1526543_ reset_password_ disable
To test:
- Load the stock catalog login page
- Notice the "Forgot your password?" link, despite the default config being 'false'
- Apply patch, leaving 'reset_password' value in config.tt2 as 'false'
- RESULT: Password reset link doesn't show up
Also, I hereby declare this unworthy of automated testing! (super simple + no existing test framework (that I know of))