Cannot disable password reset in TPAC

Bug #1526543 reported by Dan Wells on 2015-12-15
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Low
Unassigned
2.8
Low
Unassigned
2.9
Low
Unassigned

Bug Description

Evergreen 2.8+

We expect Boolean options in config.tt2 to be 'true' or 'false', but the code is simple asking 'IF reset_password', which is true for either value. Instead, match on the string (as we do in other places). Branch is incoming!

Dan Wells (dbw2) wrote :

Branch at:

working/user/dbwells/lp1526543_reset_password_disable

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dbwells/lp1526543_reset_password_disable

To test:
- Load the stock catalog login page
- Notice the "Forgot your password?" link, despite the default config being 'false'
- Apply patch, leaving 'reset_password' value in config.tt2 as 'false'
- RESULT: Password reset link doesn't show up

Also, I hereby declare this unworthy of automated testing! (super simple + no existing test framework (that I know of))

Changed in evergreen:
importance: Undecided → Low
Ben Shum (bshum) wrote :

The actual default behavior is that the config.tt2 setting for 'reset_password' = true. So one has to set the value to false and then test the application of the patch.

Having done that, it looks good, so I'm pushing it to master with backports to rel_2_9 and rel_2_8.

Thanks Dan and Remington!

Changed in evergreen:
status: New → Fix Committed
Changed in evergreen:
milestone: 2.next → 2.10-beta
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers