webclient: Checkout of Lost items fails with no feedback to the user

[Kathy Lussier]

This is similar to https://bugs.launchpad.net/evergreen/+bug/1442836.

If you try to check out a lost copy in the web client, the transaction fails without any feedback to the user. See the screencast at:

https://drive.google.com/file/d/0B74gDMUDwDXqSFhyOWFHcVpJVzA/view?usp=drivesdk

We should be getting a dialog similar to the one that appears when trying to checkout a copy already checked out to another user.

[Kathy Lussier (klussier)]

I've found at least one other instance where circ is failing without feedback to the user.

On webby, if you try to check out item 595040953380 to patron, the circ will fail with no message. The copy in question has a reserves status with a due date. I'm not quite sure how it would have a Reserves status and due date at the same time, but there does need to be some kind of feedback in these situations. When attempting to check out the same item in the xul client, we get the same message that typically appears with an Open Circulation. Other open circulation checkouts have been behaving as expected.

[Bill Erickson (berick)]

Code pushed:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1522635-webstaff-lost-co-err

I did not specifically test copies other then LOST, but this should resolve those as well. In short, the API call used to fetch the open circ only fleshed the open circs when the copy in question had a status of checked-out. In the case of LOST, etc, the .circulations() array was null (causing an exception). I replaced that call with a pcrud call, which fetches the circ regardless of the copy status.

[Mike Rylander (mrylander)]

Picked into the to-be-merged sprint-3 branch. Thanks, Bill!