webclient: delete patron action is missing

[Kathy Lussier]

The ability to delete a patron via the client is missing from the web client.

[Chris Sharp (chrissharp123)]

I'll add here my wish that the button only appear for users with the DELETE_USER perm.

[Jason Etheridge (phasefx)]

I'll augment Chris' wish with my mine, that UI elements only get disabled and not disappear based on permissions.

[Bill Erickson (berick)]

Removing assignee since no movement was made on this.

[Jeff Davis (jdavis-sitka)]

In the XUL client, the Delete Patron function is really a Completely Purge Patron function. There is also a separate feature request for enabling staff to merely flag a patron as deleted, without purging them from the system (see bug 1400829). When the existing functionality is implemented in the web client, it would be nice if we could call it something like "Completely Purge Patron" instead, to avoid confusion down the road when we eventually get a "Mark Patron as Deleted" option.

[Jason Etheridge (phasefx)]

Have a branch pushed here: collab/phasefx/webstaff-bugs-lp1517595

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commitdiff;h=613a37d30101ab124a7c2b880d6c72fc43c6c061

and

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commitdiff;h=cca34a7867cc535e6d115cedc95656a294e33401

It doesn't prompt as much on disqualifying conditions as the XUL client, but simply disables the menu entry if the account being deleted is the account logged in, or if the account has super_user status. Did not add a perm check for disabling the menu entry; I think that's a good idea but should be handled via an infrastructure feature bug.

[Andrea Neiman (aneiman)]

Noting for the record that as this is the analogue of the XUL Completely Purge Patron function, the menu labels/warnings indicate thusly as requested by Jeff Davis in comment 4 above.

I have tested this code and consent to signing off on it with my name, Andrea Neiman and my email address, <email address hidden>

[Mike Rylander (mrylander)]

Picked to master for 3.0. Thanks, Jason!