SIP Date of Birth off by one day / parsed as UTC

Bug #1516757 reported by Bill Erickson on 2015-11-16
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Medium
Unassigned
2.9
Medium
Unassigned

Bug Description

Evergreen master only (circa 2.9)

With the addition of bug #838525, user dates of birth no longer contain time or timezone information. When formatting dates in SIP, the code parses the date, defaulting to UTC since there is no timezone, then translates the value into localtime. In EST, this looks something like:

1990-01-01 => parsed as 1990-01-01 UTC => translated to local time as 1989-12-31. We lose 5 hours in the timezone conversion, so the date loses a day.

We need to tell the code to treat the originally parsed date as local time instead of UTC, which is how it behaved before (more or less) when the timezone was included in the DoB.

Patch en route.

Bill Erickson (berick) wrote :
tags: added: pullrequest
Changed in evergreen:
milestone: none → 2.next
assignee: Bill Erickson (berick) → nobody
Galen Charlton (gmc) on 2015-11-30
Changed in evergreen:
assignee: nobody → Galen Charlton (gmc)
Galen Charlton (gmc) on 2015-11-30
Changed in evergreen:
status: New → Confirmed
Galen Charlton (gmc) on 2016-03-02
Changed in evergreen:
milestone: 2.next → 2.10-rc
Galen Charlton (gmc) wrote :

Pushed, along with a test case, to master and rel_2_9. Thanks, Bill!

Changed in evergreen:
milestone: 2.10-rc → 2.10-beta
status: Confirmed → Fix Committed
assignee: Galen Charlton (gmc) → nobody
importance: Undecided → Medium
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers