Wishlist: Additional Acq Toolbar Options

Bug #1516104 reported by Chris Sharp on 2015-11-13
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Wishlist
Unassigned

Bug Description

We have a request from our libraries for two additional options for toolbars for acq. One is for the equivalent of Acquisitions -> Purchase Orders and the other is for the equivalent of Acquisitions -> Invoices.

Branch on the way.

Evergreen 2.7 through current master.

Chris Sharp (chrissharp123) wrote :

Branch finally done, thanks to Mike Peters and my efforts yesterday:

working/collab/csharp/lp1516104_acq_search_icons

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/collab/csharp/lp1516104_acq_search_icons

tags: added: needstest
tags: added: pullrequest
removed: needstest
Changed in evergreen:
milestone: 2.next → 2.10-beta

Tested new toolbar buttons on mlnc2 VM

acq_view_local_po = works as expected (equivalent of Acquisitions -> Purchase Order).

acq_view_local_inv = works as expected(equivalent of Acquisitions -> Invoices).

I have tested this code and consent to signing off on it with my email address, [<email address hidden>], and name, [Christine Burns].

Ben Shum (bshum) wrote :

Hmm, a question regarding the addition to the license.txt file. It reads currently:

"blue_acq_po_search.svg and blue_acq_invoice_search.svg derived from North of Boston Library Exchange vector graphics by Michael Peters on behalf of Georgia Public Library Service for use in the PINES consortium."

I might want to clarify that the items are being contributed and intended to be shared using the same attribution started by NOBLE (and other contributors before them). As written, I may misread that statement to mean the images are meant only to be used by PINES.

Otherwise, this work is basically ready for merge.

Chris Sharp (chrissharp123) wrote :

Wording now updated to clarify that the derivative images are subject to the original license.

Thanks, Ben!

Chris

Ben Shum (bshum) wrote :

Pushed to master.

Changed in evergreen:
status: New → Fix Committed
assignee: Chris Sharp (chrissharp123) → nobody
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers