Cannot print PO without lineitems

Bug #1510641 reported by Bill Erickson on 2015-10-27
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Undecided
Unassigned

Bug Description

Evergreen 2.9. Also confirmed in 2.5.

If a PO has zero lineitems, the actions selector, which contains the print action, is hidden. It should be possible to print a PO that only has direct charges. Blanket orders in particular do not use lineitems and will always contain only direct charges.

We could either add a 'Print PO' button, similar to how there's a dedicated 'Add Brief Record' button which displays when no lineitems are present. Or we could stop making custom additions and just always show the selector. The latter has the benefit of giving access to other actions, like viewing PO history, when no lineitems are present. If we go this route, we'll want to remove the custom "Add Brief Record" button.

Just so we don't have to revisit this again later, I'm favoring just showing the actions selector at all times in the PO instead of hiding it when no lineitems are present.

Bill Erickson (berick) wrote :

Code and release notes pushed:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1510641-print-po-sans-li

This makes the actions selector always visible. Note the batch updater and the lineitem table are still hidden until lineitems are present.

tags: added: pullrequest
Changed in evergreen:
milestone: none → 2.9.1
assignee: Bill Erickson (berick) → nobody
Galen Charlton (gmc) on 2015-11-04
Changed in evergreen:
status: New → Confirmed
assignee: nobody → Galen Charlton (gmc)
Galen Charlton (gmc) wrote :

After discussing with Bill, we've agreed that this is more of an enhancement than a bugfix, so I've pushed this to master for now. Thanks, Bill!

Changed in evergreen:
milestone: 2.9.1 → 2.next
no longer affects: evergreen/2.8
Changed in evergreen:
status: Confirmed → Fix Committed
Galen Charlton (gmc) on 2015-11-04
Changed in evergreen:
assignee: Galen Charlton (gmc) → nobody
Changed in evergreen:
milestone: 2.next → 2.10-beta
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers