infinite loop when parsing modified unclosed phrase search query

[Galen Charlton]

An unclosed phrase search that has a modifier can cause QueryParser to enter an infinite loop, tying up open-ils.storage backends.

Examples of such searches include:

  -"cats and dogs
  subject:+"physical chemistry

Evergreen 2.6 and later

[Galen Charlton (gmc)]

A patch is available at the tip of the user/gmcharlt/lp1509479_fix_qp_infinite_loop branch in the working/Evergreen repository:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gmcharlt/lp1509479_fix_qp_infinite_loop

[Dan Scott (denials)]

Sounds like a possible denial of service zero-day?

[Dan Scott (denials)]

Also wondering if it might be worthwhile to add in a simple counter that bails after a set number of loops (100 or 250 or something reasonable) to short-circuit any other possible oversights that we might have made.

[Galen Charlton (gmc)]

Thanks for the feedback. I've pushed an updated branch, user/gmcharlt/lp1509479_fix_qp_infinite_loop_take2, taking your feedback into account and fixing the typo that tsbere saw:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gmcharlt/lp1509479_fix_qp_infinite_loop_take2

[Dan Scott (denials)]

Tested cleanly, backported all the way to 2.6 for good measure. Thanks Galen!