In-house use does not display item alerts

[Jane Sandberg]

Tested using Evergreen 2.7.4. When I record in-house use for an item, I do not receive any alerts that I have applied to the item using the copy editor. I also do not receive any alerts based on the checkin alert flag on the item's copy location. It would be nice if I could turn on these alerts; our shelvers rely on them pretty heavily.

[Jason Stephenson (jstephenson)]

I plan to implement this by adding a new org_unit setting to enable the display of copy alerts during in-house use.

The open-ils.circ.in_house_use.create method will be modified to check the setting and if enabled, it will check if the copy has a copy alert. If both are true, then it will return a copy alert event for the copy.

An override variant of open-ils.circ.in_house_use.create will also be added so that the user can override the copy alert event and continue with the recording of the in-house use.

The staff clients', both XUL and Angular, in-house use interfaces will be modified to handle the copy alert event thrown by the backend and to be able to call the override version of open-ils.circ.in_house.create when the user choses to override the event.

[Jason Stephenson (jstephenson)]

After spending 4 to 5 hours modifying open-ils.circ.in_house_use.create, adding open-ils.circ.in_house_use.create.override, and writing a suite of Perl tests (most of the time was spent on getting the Perl test to work), I realized that this can be done without the backend changes.

My new approach will be to add the org_unit setting, of course. The staff clients will then check for the org_unit setting being true. If it is true and the copy has an alert message, the staff clients will then display a dialog with the alert message after the in-house-use is created. This approach is simpler and does not require the backend changes.

[Jason Stephenson (jstephenson)]

Branch in user/dyrcona/lp1507807_in-house-use_copy_alerts

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dyrcona/lp1507807_in-house-use_copy_alerts

[Dawn Dale (ddale)]

I tested this fix and I don't believe it is working. When items are recorded as in house use, I am not seeing any alerts. When items are checked in alerts are present as expected.

[Elaine Hardy (ehardy)]

I created copy alerts and location alerts for the following barcodes and locations:

Barcode Alert Message Location alert Location
CONC4400058 Testing 1507807 yes Reference
CONC4300058 Testing 1507807 yes Reference
CONC4200058 Testing 1507807 yes Reference
CONC4100058 Testing 1507807 yes Reference
CONC4000058 Testing 1507807 yes Reference
CONC41000558 Testing 1507807 no Easy Reader
CONC40000558 Testing 1507807 no Easy Reader
CONC4100058 Testing 1507807 yes Reference
CONC40000558 Testing 1507807 no Easy Reader
CONC4100046 Testing 1507807 no New Arrivals
CONC41000546 Testing 1507807 yes Reference
CONC40000601 NONE yes Reference
CONC40000101 Testing 1507807 no New Arrivals
CONC40000619 Testing 1507807 no Newspapers
CONC40000128 NONE yes Science Fiction
CONC40000537 Testing 1507807 no Young Adult Fiction

I verified Dawn's findings -- when recording inhouse use for the above barcodes, neither the copy note alert nor the copy location alert displayed.

I put all the above barcodes in bucket #1 Testing 1507807 in the Sandbox we used to test.

Elaine

[Jason Stephenson (jstephenson)]

Did you set the new org unit setting for the relevant locations?

You need to explicitly activate the behavior with the new org unit settings.

Please, see the release notes:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=blob;f=docs/RELEASE_NOTES_NEXT/Circulation/lp1507807_in-house-use_copy_alerts.adoc;h=35660329c1bcf9d1b609a324a592d0abe323fcf7;hb=6898473cf5e5b278f2740d21ffee13af8fcc855a

[Elaine Hardy (ehardy)]

We thought everything would be set up as we needed in the sandbox.... so no. Let me see what happens when we change the settings..... Sorry!

[Elaine Hardy (ehardy)]

We set the org unit for BR1 to true for both the copy note alert and the copy location alert. The copy note alert acts as expected. The copy location alert occurs even if, in the copy locations editor, the alert is set to false. Is this expected behavior?

[Jason Stephenson (jstephenson)]

In reply to "The copy location alert occurs even if, in the copy locations editor, the alert is set to false. Is this expected behavior?" from comment #8. It is not, and it shouldn't.

The staff client handles this, and I wonder if the setting change actually stuck in the staff client. I know that the staff client normally downloads its settings at start time, so if you changed it in the same session, it may not have actually changed in your staff client.

I can take another look just to make sure, though.

[Jason Stephenson (jstephenson)]

Bah! I guess what I was trying to say is, quit the staff client and sign in again to see if the location alert continues to pop up when it should not.

[Elaine Hardy (ehardy)]

I logged back in and am still getting the copy location alert even if it is set to no... see CONC40000558 and CONC40000622....

[Jason Stephenson (jstephenson)]

Can you tell me which sandbox you are using?

Thanks, Jason

[Dawn Dale (ddale)]

We are using sandbox
http://sb1.missourievergreen.org/updates/manualupdate.html

Dawn Dale
Helpdesk Manager
Georgia Public Library Service
1800 Century Place Suite 150
Atlanta, GA 30345
404-235-7136
<email address hidden>

On Thu, Jun 2, 2016 at 4:14 PM, Jason Stephenson <<email address hidden>
> wrote:

> Can you tell me which sandbox you are using?
>
> Thanks, Jason
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1507807
>
> Title:
> In-house use does not display item alerts
>
> Status in Evergreen:
> Triaged
>
> Bug description:
> Tested using Evergreen 2.7.4. When I record in-house use for an item,
> I do not receive any alerts that I have applied to the item using the
> copy editor. I also do not receive any alerts based on the checkin
> alert flag on the item's copy location. It would be nice if I could
> turn on these alerts; our shelvers rely on them pretty heavily.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/evergreen/+bug/1507807/+subscriptions
>

[Jason Stephenson (jstephenson)]

OK. Thanks for the information, everyone.

I believe I found the problem, and I'm surprised this got through the previous round of testing.

I fixed the truth checks for checkin_alert on the copy locations, rebased the branch, and force pushed to the same location.

I'll give this some more testing on my own this weekend. If anyone else wants to test in the mean time, feel free.

[Jason Stephenson (jstephenson)]

The change that I made after bug squashing day fixes it for me.

Please test again.

Thanks,
Jason

[Elaine Hardy (ehardy)]

Jason,

Is the fix on the sandbox or do we need to put it all on our test server?

J. Elaine Hardy
PINES & Collaborative Projects Manager
Georgia Public Library Service/PINES
1800 Century Place, Ste. 150
Atlanta, GA 30045

404.235.7128 Office
404.548.4241 Cell
404.235.7201 FAX

On Sun, Jun 5, 2016 at 11:27 AM, Jason Stephenson <
<email address hidden>> wrote:

> The change that I made after bug squashing day fixes it for me.
>
> Please test again.
>
> Thanks,
> Jason
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1507807
>
> Title:
> In-house use does not display item alerts
>
> Status in Evergreen:
> Triaged
>
> Bug description:
> Tested using Evergreen 2.7.4. When I record in-house use for an item,
> I do not receive any alerts that I have applied to the item using the
> copy editor. I also do not receive any alerts based on the checkin
> alert flag on the item's copy location. It would be nice if I could
> turn on these alerts; our shelvers rely on them pretty heavily.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/evergreen/+bug/1507807/+subscriptions
>

[Jason Stephenson (jstephenson)]

On 06/06/2016 07:45 AM, Elaine Hardy wrote:
> Is the fix on the sandbox or do we need to put it all on our test
> server?

It is not on the sandbox as far as I know. It would need to be reloaded
there or on another test server.

[Dawn Dale (ddale)]

I tested the patch on our server and it does work as expected now.

[Kathy Lussier (klussier)]

Hi Dawn,

Thanks for following up and testing the new code! Could you add a signoff to the bug by adding a comment in the following format?:

"I have tested this code and consent to signing off on it with my name, [enter name or consistent alias] and my email address, [enter email address]."

Thanks!
Kathy

[Kathy Lussier (klussier)]

I'm getting merge conflicts on this branch. Could you resolve them Jason? Thanks!

Kathy

[Jason Stephenson (jstephenson)]

OK. Rebased on master and force-pushed over the existing branch.

[Kathy Lussier (klussier)]

Tested in the xul and web client, and the alerts appeared as expected. Signed off and merged to master for inclusion in 2.12.

Thanks Jason, Dawn and Elaine!