Staff client refund option generates an error

[Kathy Lussier]

Evergreen version: 2.9RC

Tested on the MassLNC community demo server. Retrieve a patron record with a negative balance in the patron's bills interface, right-click on the transaction and select the "Refund" option. The client generates the following error:

*** Failed to get string staff.patron.bills.handle_refund.confirm_message in bundle: /xul/2015_09mlnc4_09_095756/server/locale/en-US/patron.properties
undefined

[Kathy Lussier (klussier)]

This working branch restores the refund function back to its behavior in 2.8:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/kmlussier/lp1494427-fix-refund-error

However, I also want to make note that, although I've added the staff.patron.bills.handle_refund.confirm_message back to the patron.properties file, as far as I can tell, this string never gets displayed. It didn't display in 2.8 either.

I was tempted to just remove the string from the handle_refund function in bill2.js, but I was worried that the string was being displayed somewhere and I was just missing it. I'm happy to do a new branch to remove the string from the function if it's a better approach.

Test case:

Find a negative balance transaction and, from the patron's bills
record, select the transaction and select the option to Refund. Pre-patch, this
action will generate an error message. Post-patch, this action should generate
a prompt asking the user to confirm the action.

[Kathy Lussier (klussier)]

Alternate approach that removes the unused string along with a similar unused string in the adjust-to-zero function is available at:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/kmlussier/lp1494427-fix-refund-error

[Jason Etheridge (phasefx)]

I think Kathy meant this one:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/kmlussier/lp1494427-fix-refund-error-by-removing-string

Using null looks good to me.

[Kathy Lussier (klussier)]

Thanks for correcting my link Jason!

[Jason Stephenson (jstephenson)]

Works for me! Pushed to master for 2.9.0. Thanks, Kathy!