"Staff-Generated Penalties/Messages" label in patron display form misleading

[Dan Scott]

* Evergreen 2.7, as well as webby

When you click on the "Messages" tab of the Patron record, the pane shows a header of "Staff-Generated Penalties/Messages".

However, in our case the vast majority of the penalties are system-generated. This could be a bit confusing (and has been for us), as staff try to figure out who placed a given block.

I also noticed that the same label is currently used in the web-based staff client.

My recommendation is to simply change the label to "Penalties and Messages".

[Dan Scott (denials)]

See the top two commits on http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dbs/lp1490616_penalties_messages_label (split so that the XUL can be backported, if desired, all the way to 2.7).

[Ben Shum (bshum)]

Gah, this got missed because we forgot to assign a target/pullrequest.

Pointing it towards 2.next for now with an eye to get it sorted soon.

[Heather Lindskold (heatherlindskold)]

In webby this is additionally confusing because the messages for system-generated penalties show in the patron summary--in the Messages tab they show that a message was applied but do NOT show the text of the message.

[Ben Shum (bshum)]

Picked to master for 3.3. Since this is a string change, I'm deciding not to backport it to past releases for the time being and only make this change for the future. Also, only applying the web-client change commit now that XUL is out.

Re: Katie's note, that might belong to a separate bug to flesh out the penalty text in the web interface.