public.first_agg needs test

Bug #1483506 reported by Liam Whalen on 2015-08-11
This bug affects 1 person
Affects Status Importance Assigned to Milestone

Bug Description

Test Writing Day - 2015/08/14

public.first_agg is a potential target for tests.

Liam Whalen (whalen-ld) on 2015-08-11
tags: added: test-writing-day-0
Yamil (ysuarez) on 2015-08-12
Changed in evergreen:
assignee: nobody → Yamil (ysuarez)
Yamil (ysuarez) wrote :

I also did a test for public.first which relies on public.first_agg.

Here is my working branch...;a=shortlog;h=refs/heads/user/ysuarez/lp1483506_public.first_agg_pgtap

tags: added: pullrequest
Yamil (ysuarez) wrote :

I added a pull request, but I think I should first get a sign-off?

Changed in evergreen:
assignee: Yamil (ysuarez) → nobody


Tested on a 8/22/2015 version of Master, all the tests passed, looks good.

postgres@virt-egtestapp4:/home/opensrf/Evergreen/Open-ILS/src/sql/Pg/t$ pg_prove -d evergreen -v ..
ok 1 - testing having two interger parameters; picking first parameter
ok 2 - testing having two string parameters; picking first parameter
ok ......
ok 1 - testing having three rows; picking first row
ok 2 - testing having one row; picking first row
All tests successful.
Files=2, Tests=4, 0 wallclock secs ( 0.07 usr 0.01 sys + 0.17 cusr 0.04 csys = 0.29 CPU)
Result: PASS

tags: added: signedoff
Kathy Lussier (klussier) wrote :

Thank you Yamil and Josh!

Merged to master.

Changed in evergreen:
status: New → Fix Committed
milestone: none →
Liam Whalen (whalen-ld) on 2015-11-17
tags: removed: test-writing-day-0
Changed in evergreen:
milestone: → 2.10-beta
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers