evergreen.lowercase needs test

Bug #1483500 reported by Liam Whalen on 2015-08-11
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Undecided
Unassigned

Bug Description

Test Writing Day - 2015/08/14

evergreen.lowercase is a potential target for a test.

Liam Whalen (whalen-ld) on 2015-08-11
tags: added: test-writing-day-0
Changed in evergreen:
assignee: nobody → Josh Stompro (u-launchpad-stompro-org)
Dan Scott (denials) wrote :

Suggestion: include some examples of Unicode (e.g. É -> é)?

Yamil (ysuarez) wrote :

Josh,

Found this file that you can use to get ideas of how to thoroughly test with unicode examples....

Open-ILS/src/sql/Pg/t/naco_normalize.pg

http://git.evergreen-ils.org/?p=Evergreen.git;a=blob;f=Open-ILS/src/sql/Pg/t/naco_normalize.pg;h=0e59107e99886d79e7349b9acb700a8efb8899c9;hb=HEAD

God luck,
Yamil

Branch at
working user/stompro/lp1483500_pgtap_evergreen_lowercase

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/stompro/lp1483500_pgtap_evergreen_lowercase

I think I might have found a bug in evergreen.lowercase when handling Turkish characters. There are two i's in the Turkish character set, İ-> i, I -> ı, Capitol I with a dot, and without a dot, and lowercase versions of each. But select evergreen.lowercase('İI'); returns " i̇i" when it should return "iı". But I would like someone that has more UNICODE experience to confirm it.

This site talks about the double I problems.
http://www.i18nguy.com/unicode/turkish-i18n.html#problem

I also can now think of an instance where I used the built in Postgresq lower() function that might break with unicode characters. I'll go back and fix that.

Josh

tags: added: pgtap pullrequest
Changed in evergreen:
assignee: Josh Stompro (u-launchpad-stompro-org) → nobody
Changed in evergreen:
status: New → Confirmed
Yamil (ysuarez) wrote :

The pgTAP test passed

pg_prove -U evergreen lowercase.pg
lowercase.pg .. ok
All tests successful.
Files=1, Tests=7, 0 wallclock secs ( 0.02 usr 0.01 sys + 0.02 cusr 0.04 csys = 0.09 CPU)
Result: PASS

here is my sign off branch:
http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/ysuarez/lp1483500_pgtap_evergreen_lowercase_signoff

Yamil (ysuarez) on 2015-08-25
tags: added: signedoff
Kathy Lussier (klussier) wrote :

Looks good to me. Merged to master.

Thank you Josh and Yamil!

Changed in evergreen:
milestone: none → 2.next
status: Confirmed → Fix Committed
Liam Whalen (whalen-ld) on 2015-11-17
tags: removed: test-writing-day-0
Changed in evergreen:
milestone: 2.next → 2.10-beta
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers