Show link should display for both available and unavailable copies

Bug #1481844 reported by Kathy Lussier
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Wishlist
Unassigned

Bug Description

Evergreen version: all

Previously discussed in the email thread at http://markmail.org/thread/npittk47lkihq7kg

The "Show" link on the record summary page only displays for OUs that have available copies. However, there are often times when users want to see the status of copies throughout the consortium even if they are currently unavailable.

Following the recommendations from the above-mentioned mailing thread, I'll be posting code that will change the text that displays in the available copies area to read:

x of y copies available at z

The code will also display the "Show" link for any OUs that own a copy, even if all those copies are unavailable.

Tags: pullrequest
Revision history for this message
Kathy Lussier (klussier) wrote :
Changed in evergreen:
assignee: Kathy Lussier (klussier) → nobody
tags: added: pullrequest
Changed in evergreen:
milestone: 2.9-alpha → 2.9-beta
Changed in evergreen:
assignee: nobody → Jason Stephenson (jstephenson)
Revision history for this message
Jason Stephenson (jstephenson) wrote :

Turns out, we've customized that bit away, so I can't reasonably look at this.

Someone else, please have a look.

Changed in evergreen:
assignee: Jason Stephenson (jstephenson) → nobody
Revision history for this message
Kathy Lussier (klussier) wrote :

Looks like I missed a needed change here. Temporarily removing the pullrequest tag.

tags: removed: pullrequest
Revision history for this message
Kathy Lussier (klussier) wrote :

I force pushed an update to display the show link if the OU owns a copy. Adding the pullrequest tag again.

I also just discovered a duplicate bug, with code submitted, at https://bugs.launchpad.net/evergreen/+bug/1050039 . The difference in that branch is that it turns the entire x of y copies available at z phrase into a link rather than continuing to display the Show link. My preference is to continue using the "Show" link since it matches the consensus reached in that mail thread.

Jason, I looked at your catalog, and I don't think it's been customized away. You just need to arrive at the record in the right context.

Take a look at:

http://catalog.mvlc.org/eg/opac/record/501069?query=harry%20potter%20goblet%20fire;qtype=keyword;locg=5

where you can see the "Show" link to see the available copies in MVLC

versus

http://catalog.mvlc.org/eg/opac/record/1604767?query=go%20set%20a%20watchman;qtype=keyword;locg=5

where no "Show" link displays because there aren't any available copies.

Thanks everyone!

tags: added: pullrequest
Revision history for this message
Ben Shum (bshum) wrote :

Hi Kathy, since the bug was originally mine and your solution is parallel to what I tried in my bug, I'm going to take your solution (which I like more) and push it to master and get rid of the old bug by marking it a dupe of this one.

Cheers and thanks!

Changed in evergreen:
status: New → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.