Replace manual void option with an "adjust to zero" option

Bug #1479107 reported by Kathy Lussier
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fix Released

Bug Description

Evergreen version: master

With the new conditional negative balances code from, we still have one known scenario where a site with the "Prohibit Negative Balances" setting enabled will continue to produce negative balances. Manually voiding a bill in the staff client will produce a negative balance regardless of the use of that setting.

After discussion in IRC - - we are looking at removing the current void option and replacing it with an "adjust to zero" option that will always adjust the bill down to zero.

Tags: signedoff
Dan Wells (dbw2)
Changed in evergreen:
assignee: nobody → Dan Wells (dbw2)
Changed in evergreen:
milestone: none → 2.9-beta
Revision history for this message
Dan Wells (dbw2) wrote :

Okay, rough cut is here:;a=shortlog;h=refs/heads/user/dbwells/lp1479107_adjust_to_zero_interface


Like I said, it is rough, but it might be beta-worthy, and is very unlikely to break anything.

Revision history for this message
Kathy Lussier (klussier) wrote :

Works for me, both for partially-paid bills and for negative balances that should be removed from the record. Signoff is available at;a=shortlog;h=refs/heads/user/kmlussier/lp1479107_adjust_to_zero_interface

From my testing, it looks like this code also fulfills the functionality requested at .

Should we close that bug too?

tags: added: signedoff
Changed in evergreen:
assignee: Dan Wells (dbw2) → nobody
Revision history for this message
Jason Stephenson (jstephenson) wrote :

Pushed to master for great justice!

Thanks, Dan and Kathy!

Changed in evergreen:
status: New → Fix Committed
Revision history for this message
Dan Wells (dbw2) wrote :

Okay, I pushed on a couple new tests to specifically flex these new API bits. It's the tip of the same branch:;a=commitdiff;h=227af4a527c19c660315cd14f2a6e8a115d8558d

Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.