Replace manual void option with an "adjust to zero" option

Bug #1479107 reported by Kathy Lussier on 2015-07-28
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Medium
Unassigned

Bug Description

Evergreen version: master

With the new conditional negative balances code from https://bugs.launchpad.net/evergreen/+bug/1198465, we still have one known scenario where a site with the "Prohibit Negative Balances" setting enabled will continue to produce negative balances. Manually voiding a bill in the staff client will produce a negative balance regardless of the use of that setting.

After discussion in IRC - http://irc.evergreen-ils.org/evergreen/2015-07-22#i_190842 - we are looking at removing the current void option and replacing it with an "adjust to zero" option that will always adjust the bill down to zero.

Dan Wells (dbw2) on 2015-08-18
Changed in evergreen:
assignee: nobody → Dan Wells (dbw2)
Changed in evergreen:
milestone: none → 2.9-beta
Dan Wells (dbw2) wrote :

Okay, rough cut is here:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dbwells/lp1479107_adjust_to_zero_interface

working/user/dbwells/lp1479107_adjust_to_zero_interface

Like I said, it is rough, but it might be beta-worthy, and is very unlikely to break anything.

Kathy Lussier (klussier) wrote :

Works for me, both for partially-paid bills and for negative balances that should be removed from the record. Signoff is available at

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/kmlussier/lp1479107_adjust_to_zero_interface

From my testing, it looks like this code also fulfills the functionality requested at https://bugs.launchpad.net/evergreen/+bug/1249398 .

Should we close that bug too?

tags: added: signedoff
Changed in evergreen:
assignee: Dan Wells (dbw2) → nobody
Jason Stephenson (jstephenson) wrote :

Pushed to master for great justice!

Thanks, Dan and Kathy!

Changed in evergreen:
status: New → Fix Committed
Dan Wells (dbw2) wrote :

Okay, I pushed on a couple new tests to specifically flex these new API bits. It's the tip of the same branch:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commitdiff;h=227af4a527c19c660315cd14f2a6e8a115d8558d

Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers