Staff client patron items out no longer sorts overdue to top

[Bill Erickson]

Evergreen 2.8, goes back to 2.5.

Before the introduction of code from bug #1212456, the staff client sorted overdue items to the top of the items out display. This was done by inserting the list of overdues into the grid before the regular items out. (No date sorting, etc.).

The delightfully simple fix is to swap these two lines in items.js:

            obj.checkouts = obj.checkouts.concat(robj.out);
            obj.checkouts = obj.checkouts.concat(robj.overdue);

We could probably do more to improve the default sort (see bug #1125567), but in the meantime, I think it's sane to recover the previous behavior.

Note: this affects the browser client as well.

Patch for the XUL bits en route.

[Bill Erickson (berick)]

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1478997-items-out-sort-overdue

[Bill Erickson (berick)]

Fix for webstaff version. This is master-only only, of course:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1478997-items-out-sort-overdue-webstaff

[Ben Shum (bshum)]

Seems logical enough. Pushed the first change to master, with backports to rel_2_8 and rel_2_7. The second change was only pushed to master for the web staff client only.