Fix hold permit test

Bug #1478299 reported by Kathy Lussier
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Undecided
Unassigned

Bug Description

When we added copy locations to the sample data in https://bugs.launchpad.net/evergreen/+bug/1155771, we accidentally applied a non-holdable copy location to the copy used in the hold permit pgTAP test, causing the test to fail. The forthcoming branch will change the copy used in the test to one that is holdable.

Tags: pullrequest
Revision history for this message
Kathy Lussier (klussier) wrote :
tags: added: pullrequest
Revision history for this message
Jason Etheridge (phasefx) wrote :

Kathy, you beat me to it :) I have a different take on a fix:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/collab/phasefx/lp1155771qa

I'm leaning toward mine as being more predictable, but what do others think?

Revision history for this message
Ben Shum (bshum) wrote :

Went with Jason's solution since it seems like it would be more consistent. Pushed to master for good justice.

Thanks!

Changed in evergreen:
status: New → Fix Committed
milestone: none → 2.9-alpha
Changed in evergreen:
milestone: 2.9-alpha → 2.9-beta
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.