Global Flags Label Typo - Hold Retention Age - Untargeted

[Josh Stompro]

The label for the global flag history.hold.retention_age_canceled_1 is set to "Historical Hold Retention Age - Canceled (Untarged expiration)"

I think that Untarged should be Untargeted, as in expire holds that have sat untargeted for the specified amount of time.

http://git.evergreen-ils.org/?p=Evergreen.git;a=blob;f=Open-ILS/src/sql/Pg/950.data.seed-values.sql;hb=HEAD#l9728

Josh

[Andrea Neiman (aneiman)]

Confirmed, still seeing the typo in 2.12.3

[Jane Sandberg (sandbergja)]

For anybody that might want to take this on, here's a good example commit for a change to the global flag label: https://github.com/evergreen-library-system/Evergreen/commit/7853a5faa9d2e5c1d392f04c2dbb85d0f358345f

But instead of the "INSERT INTO config.upgrade_log" line, I suspect you'll want to do:

--SELECT evergreen.upgrade_deps_block_check('XXXX', :eg_version);