Expert Search Ignores Search Library in Staff Client

[Jennifer Pringle]

Evergreen 2.8.1 (and 2.6)

When performing an Expert Search in the staff client (Cataloging -> Search the Catalog -> Expert Search) the Evergreen ignores the library specified under Search Library and instead returns results for your entire bibliographic database. If you do the same search in the OPAC (Advanced Search -> Expert Search) the system only retrieves the records for your specified search library.

I've tested this on our current 2.6 server and our 2.8.1 test server and I see the same results on both.

For example, in the Expert Search search:
Tag: 300
Subfield: e
Value: 1 cd

In our system I get 14 results when searching in the OPAC with the search library set to a specific library.
If I do the exact same search in the staff client with the search library set to the same specific library I get 1928 results. No matter what library I select in the staff client I always get 1928 results.

The Expert Search in the staff client should behave the same in the staff client as it does in the OPAC and scope the results based on the search library.

[Erica Rohlfs (erohlfs)]

Confirmed in version 2.8.1.

[Jennifer Pringle (jpringle-u)]

Confirmed still an issue in 2.10.2

[Jennifer Pringle (jpringle-u)]

Confirmed still an issue in 3.3

[Lynn Floyd (lfloyd)]

Confirmed still an issue in 3.4.1

[Elizabeth Thomsen (et-8)]

Confirmed on the "Experimental" Staff Catalog on Release 3.5.1

[Bill Erickson (berick)]

The UI is passing the org unit to the server API, but since it's a "staff" call, it essentially ignores the visibility of holdings and returns all results. It's acting as if "Results from All Libraries" were checked, even though no such checkbox exists.

Do we need a "Results from All Libraries" checkbox on the MARC search tab or should it simply honor the org unit scope automatically?

[Ruth Frasur Davis (redavis)]

Having the "results from ALL libraries" checkbox would be preferable.

[Elaine Hardy (ehardy)]

+1

[Bill Erickson (berick)]

Here's a branch:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1468132-marc-search-all-results

1. Adds a 'Results from ALL libraries' checkbox.

2. Fixes the staff version of the MARC search API so that it filters on the existence of copies when searching at a non-zero depth, similar to regular keyword searches. Previously, all staff searches were global regardless of scope.

[Ruth Frasur Davis (redavis)]

It someone throws this up on a test server, I'd be glad to test it.

[Elaine Hardy (ehardy)]

Tested on https://acorn.evergreencatalog.com/eg/staff/

I removed all copies on record #31 except those for BR1.

Searched for record by 245 $a concerto, 1800-1900 and filtered for example system 2. The record was retrieved. Tried several other libs and record was retrieved in all searches.

[Bill Erickson (berick)]

A note to test server builders, this change includes Perl modifications, so an Angular-only update will not suffice.

[Michele Morgan (mmorgan)]

I've tested this on the Feedback Fest test server festivus.evergreencatalog.com in the Angular Staff Catalog. I see the "Results from All Libraries" checkbox, but am not seeing any difference in search results when the checkbox is checked.

I added a record with a single holding at BR1, but this record shows up in the results of a MARC Expert search no matter what search library I choose.

I am wondering if the perl change Bill mentions in comment #12 was applied? It looks like the top two commits of Bills branch are needed. The earlier commit would be easy to miss since it looks like it has the wrong bug number.

[Michele Morgan (mmorgan)]

Had another go at this on a local test server, making sure to cherry-pick both commits. This works as advertised, respecting the selected scope in the MARC Expert search unless the "Results from All Libraries" box is checked.

My signoff is at:

user/mmorgan/lp1468132_marc_search_scope_signoff

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mmorgan/lp1468132_marc_search_scope_signoff

[Jason Boyer (jboyer)]

Pushed to rel_3_5, rel_3_6, and master. Thanks Bill and Michele!